Fix in ping telegraf plugin, the "count" to be a "arguments".

[alexwbaule]

its the correct way to configure ping to use the "binary" file. (the "count" is a parameter passed to the ping binary).

[alexwbaule]

Hi @fichtner ,

that's the correct way to configure the ping using the binary file.

fix the revert made in #4349 because the #4316 and #4317

[fichtner]

can we set binary for ipv6 case too for consistency? arguments look correct, ping6 binary appears to be deprecated. maybe it's worth asking for wider testing in the other thread first.

[alexwbaule]

@fichtner , yeap.. we can...

I'm set the ping because is the same binary, and if you call the "--help" on each binary, the response is the same, you must pass the "-6" as argument too, to ping6 a ipv6 address or host.

i will revert to "ping6", but keeping the "-6" as argument, like is recommended by the --help from ping/ping6.

[fichtner]

Meh sorry typo, I meant the binary for IPv4. “ping -6” was better. “ping” these days is ambiguous on host names so “ping -4” makes sense. “ping6” already implies “-6” … hope I remember this correctly.

[alexwbaule]

@fichtner, im think too, that "ping6" implies "-6", but testing here i got some strange behavior, like ping ipv4 on "ping6" and vice-versa. Thats why i force the argument "-6" and "-4"...

Im tested here, with "run as root" unchecked, and works fine.

[alexwbaule]

@fichtner it will be merged ?

[fichtner]

I'd rather like to get rid of binary = "ping6" here for symmetry

[alexwbaule]

Ok, when I get at home i will update it.

[fichtner]

@alexwbaule ping :)

[alexwbaule]

Sorry @fichtner , I forgot ! To many things to do... Promess, today !

[alexwbaule]

@fichtner , done ! Sorry about the delay.

[fichtner]

No worries, merged, thanks!