net/mdns-repeater: Modernize plugin code; Add blocklist support (contributed by Kodehyrden)#4375
Merged
Monviech merged 7 commits intoopnsense:masterfrom Dec 6, 2024
Monviech:mdnsrepeater-cleanup
Merged
net/mdns-repeater: Modernize plugin code; Add blocklist support (contributed by Kodehyrden)#4375Monviech merged 7 commits intoopnsense:masterfrom Monviech:mdnsrepeater-cleanup
Monviech merged 7 commits intoopnsense:masterfrom
Monviech:mdnsrepeater-cleanup
Conversation
|
Maybe we should think about a centralized DNSBL, every service seems to use its own set of blacklists, Unbound, dnscrypt-proxy and now mdns-repeater. |
fichtner
reviewed
Dec 4, 2024
fichtner
reviewed
Dec 4, 2024
| <Required>Y</Required> | ||
| <Multiple>Y</Multiple> | ||
| </interfaces> | ||
| <blacklist type="NetworkField"> |
Member
There was a problem hiding this comment.
let's please call this "blocklist"
Member
Author
There was a problem hiding this comment.
But its called blacklist in source:
fichtner
reviewed
Dec 4, 2024
net/mdns-repeater/src/opnsense/mvc/app/views/OPNsense/MDNSRepeater/index.volt
Outdated
Show resolved
Hide resolved
fichtner
reviewed
Dec 4, 2024
fichtner
changed the title
Co-authored-by: Franco Fichtner <franco@lastsummer.de>
…ater/index.volt Co-authored-by: Franco Fichtner <franco@lastsummer.de>
Co-authored-by: Franco Fichtner <franco@lastsummer.de>
fichtner
approved these changes
Dec 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A general cleanup of the plugin code because I was tracing a bug in the view with tokenized fields but it caused a chain reaction that resulted in this PR.
This includes: #4362