Skip to content

Remove wrong class for HTTP(S) settings#667

Closed
fzoske wants to merge 1 commit intoopnsense:masterfrom
fzoske:master
Closed

Remove wrong class for HTTP(S) settings#667
fzoske wants to merge 1 commit intoopnsense:masterfrom
fzoske:master

Conversation

@fzoske
Copy link
Copy Markdown
Contributor

@fzoske fzoske commented May 11, 2018

The section is not visible when the dialog is first loaded. Only after switching from http to SSL(TCP) or TCP and back made the option visible.

As of the moment there it only one option in this section and it is related to http mode.
Using it in SSL (TCP) mode does not work:
[WARNING] 130/221244 (37870) : config : 'option forwardfor' ignored for frontend '<FE>' as it requires HTTP mode.

Therefore the easiest option seems to remove the unnecessary class from the view.

Best regards,
Fabian

@fzoske
Copy link
Copy Markdown
Contributor Author

fzoske commented May 16, 2018

It's the same change made here

@fzoske fzoske closed this May 16, 2018
@fzoske fzoske reopened this May 16, 2018
@fraenki
Copy link
Copy Markdown
Member

fraenki commented May 17, 2018

@fzoske Thanks! I wanted to fix this a long time ago, but was unable to do so due to time constraints. I've merged #579 which should fix this issue.

@fraenki fraenki closed this May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants