Conversation
fraenki
left a comment
fraenki
left a comment
There was a problem hiding this comment.
Looks good to me. 👍 I'm going to test the patch later today before approving it.
|
@fraenki merge this for 17.1.3's devel version? |
|
👍 |
|
That is a yes, no? :D |
|
yes :) |
|
@fkling Thank you! If all goes well, this will be released with 17.1.4. On the upcoming 17.1.3, you can see the plugin from the GUI when you have the development version installed: Changing back to the release via: Or you could also manually install the plugin's development version to test your changes: |
| <type>text</type> | ||
| <help></help> | ||
| </field> | ||
| <field> |
There was a problem hiding this comment.
I really don't like this strings as they are really questionable when it comes to translation.
Is "DNS-01/" really required or would it be possible to have "Linode" as a single string here impossible / would loose context?
There was a problem hiding this comment.
Let's see how Ad's latest JavaScript magic works out. The prefix was added to have a destinction in the GUI between HTTP-01 and DNS-01 validation methods.
There was a problem hiding this comment.
Fabian is right. But FWIW this isn't going to be in the translation templates for a few months, hopefully by then we have a nicer solution.
|
Thank you everybody! |
4 participants
See #82 for context. As I mentioned there, I wasn't able to cleanly patch opensense via
opnsense-patch, so I don't know if my changes actually work. It seemsopnsense-patchtries to patch files into/usr/local/security/acme-client/src/opnsense/...instead of/usr/local/opnsense/..., which makes sense since that's the directory structure of the repo, but I don't know how to change that.I simply copied the
acme.shfile and all files indnsapi/and editedcerthelper.php,dialogValidation.xmlandAcmeClient.xmlto the best of my abilities.