Hotfix/http request before use backend#999
Merged
fraenki merged 9 commits intoopnsense:masterfrom Nov 25, 2018
Merged
Conversation
added 4 commits
November 17, 2018 03:41
fraenki
requested changes
Nov 20, 2018
net/haproxy/src/opnsense/service/templates/OPNsense/HAProxy/haproxy.conf
Show resolved
Hide resolved
net/haproxy/src/opnsense/service/templates/OPNsense/HAProxy/haproxy.conf
Show resolved
Hide resolved
net/haproxy/src/opnsense/service/templates/OPNsense/HAProxy/haproxy.conf
Outdated
Show resolved
Hide resolved
added 5 commits
November 21, 2018 02:26
This comment has been minimized.
This comment has been minimized.
fraenki
added a commit
to fraenki/plugins
that referenced
this pull request
Nov 25, 2018
When enabling stats and peers, these two sections git messed up due to a missing newline.
fraenki
added a commit
to fraenki/plugins
that referenced
this pull request
Nov 25, 2018
When enabling both stats and peers, these two sections got messed up due to a missing newline.
Member
|
@mathiasaerts Merged, thanks! |
fraenki
added a commit
to fraenki/plugins
that referenced
this pull request
Nov 25, 2018
When enabling both stats and peers, these two sections got messed up due to a missing newline.
Contributor
Author
|
@fraenki Awesome, thanks! |
fraenki
added a commit
to fraenki/plugins
that referenced
this pull request
Jul 24, 2020
…pnsense#999 This partially reverts 1f9250e.
Member
|
A small heads-up: the upcoming os-haproxy 2.24 will change this behavior again. It will solely rely on proper sorting of the rules, the special handling of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When adding an HTTP to HTTPS redirect for some URLs in the haproxy configuration, I was getting the warning messages below.
use_backendandhttp-requestrules are added to the haproxy frontend section in no specific order.I've adjusted the template so that
use_*statements are always last in the frontend section. I tried to simplify the code as much as possible (with my limited Jinja2 knowledge) but perhaps there is a better way. I've also removed some extra newlines to keep the generated config file clean.I'm running Opnsense 18.7.7 and noticed that the template is a bit different from the
masterbranch. I've made and tested my adjustments with this version before rebasing (dee6c58) with the current master branch (not sure how to test this).