fix: linting errors#469
Merged
samuelstroschein merged 2 commits intoopral:mainfrom Mar 27, 2023
Merged
Conversation
🦋 Changeset detectedLatest commit: 6901fd3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
|
@boian-ivanov Thank you very much! Besides the linting errors, how can we improve the "getting started" with the codebase experience? |
samuelstroschein
pushed a commit
that referenced
this pull request
Mar 27, 2023
* fix: linting errors * chore: add changeset
samuelstroschein
added a commit
that referenced
this pull request
Mar 27, 2023
commit b8cdf3f Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon Mar 27 18:43:22 2023 +0200 Version Packages (#456) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit e9e9ce5 Author: Samuel Stroschein <35429197+samuelstroschein@users.noreply.github.com> Date: Mon Mar 27 18:35:32 2023 +0200 refactor: simplify core/lint (#459) * refactor: remove setup and teardown * work in progress commit * refactor: remove the concept of passing booleans to the lint level * fix: propagation of context Context can't be passed around from nodes to childs without adjusting the target and reference nodes. * chore: simplify type The generic output was unused. * test: slightly more realistic test * refactor: remove context Redundant concept. * init alternative * refactor: define setup function in `LintRule` #459 (comment) * clean up * refactor: remove rule collections 😢 We should wait for user demand to nail a solution. * update readme * refactor: remove unusued utilities The `utilities` lib is intended for external usage. Furthermore, most utilties were not used. * add: typesafety to createLintRule settings * chore: fix type imports * chore: fix typescript compilation * chore: remove test utilities export The utilities like `createMessage` should likely be part of `ast`. Exposing them only for lint seems a short term solution. But, if we expose those utiltites in lint now, we can't remove them in the future. Thus, remove for now. * refactor: return errors to enable apps to handle errors Encountered numerous problems because `lint` implicitly catches errors. That behavior makes sense. Just because one rule is throwing, the linting process shouldn't abort. However, debugging became harder and consuming apps like the editor or CLI will never now if a linting process failed. * fix typo Co-authored-by: Hofer Ivan <ivan.hofer@outlook.com> * fix typo Co-authored-by: Hofer Ivan <ivan.hofer@outlook.com> * show example lint rule with settings * chore: remove todo * fix: only pass message to a node * chore: add comment to remove node types * refactor: narrow settings type * refactor: createLintRule only uses args #459 (comment) * chore: don't use node globals * refactor: remove node dependency entirely node fs imports don't work in core * refactor: remove node dependency entirely node fs imports don't work in core * refactor: remove node dependency entirely node fs imports don't work in core * fix: pass correct args * Create .changeset/hungry-carpets-build.md --------- Co-authored-by: Hofer Ivan <ivan.hofer@outlook.com> commit f87f300 Author: Boian Ivanov <boian.ivanov44@gmail.com> Date: Mon Mar 27 15:28:45 2023 +0100 chore: linting errors (#469) * fix: linting errors * chore: add changeset commit 2d3c8cc Author: NiklasBuchfink <niklas.buchfink@web.de> Date: Mon Mar 27 08:31:09 2023 +0000 refactor: svg logo in website layout commit b13dfa8 Author: Ivan Hofer <ivan.hofer@outlook.com> Date: Sat Mar 25 11:07:37 2023 +0100 run npm i commit 704c83d Author: Hofer Ivan <ivan.hofer@outlook.com> Date: Sat Mar 25 10:16:04 2023 +0100 add sdk-js RFC (#460) commit 4992681 Author: Niklas Buchfink <59048346+NiklasBuchfink@users.noreply.github.com> Date: Thu Mar 23 19:12:45 2023 +0100 Editor condense textarea (#461) commit 277e5ae Author: NiklasBuchfink <niklas.buchfink@web.de> Date: Tue Mar 21 10:05:51 2023 +0000 add: discord invite to footer commit 0a2de81 Author: NiklasBuchfink <niklas.buchfink@web.de> Date: Mon Mar 20 16:13:46 2023 +0000 add discord invite icon to header commit a0b85eb Author: Samuel Stroschein <35429197+samuelstroschein@users.noreply.github.com> Date: Mon Mar 20 12:52:43 2023 +0100 refactor: improve core/lint (#453) * refactor: use minimum config schema, remove env from lint * chore: format fix * refactor: only expose 2 query functions * chore: add changeset * chore: remove unnecessary optional chaining * refactor: don't return undefined in lint #453 (comment) * refactor: immutable lint commit e3fb6a3 Author: NiklasBuchfink <niklas.buchfink@web.de> Date: Mon Mar 20 10:14:06 2023 +0000 fix contact mail in footer commit 1a6ccec Author: Nikita <nikita.voloboev@gmail.com> Date: Mon Mar 20 02:25:45 2023 +0100 add: do shallow clone (#454) * do git clone with depth 1 * add git shallow clone for fast UI response with fetching rest of history in background * comment * fix prettier commit 6c8a576 Author: Samuel Stroschein <35429197+samuelstroschein@users.noreply.github.com> Date: Sun Mar 19 12:53:22 2023 +0100 Update repositories.ts knadh/listmonk#1189 commit 6dbdfc7 Author: Robin Bühler <git+r@obin.ch> Date: Fri Mar 17 14:32:45 2023 +0000 chore: add ide-extension publication to ci-cd env commit a4581da Author: Robin Bühler <git+r@obin.ch> Date: Fri Mar 17 14:23:39 2023 +0000 chroe: change vsce token env commit 53423d6 Author: Robin Bühler <git+r@obin.ch> Date: Fri Mar 17 13:57:41 2023 +0000 chore: run vsce with npx commit 042bfab Author: Robin Bühler <git+r@obin.ch> Date: Fri Mar 17 13:51:23 2023 +0000 chore: enhance publis-ide-extension-to-marketplace.yml commit bdbbf8e Author: Robin Bühler <git+r@obin.ch> Date: Fri Mar 17 13:38:49 2023 +0000 chore: update package-lock.json commit 8f73244 Author: Robin Bühler <1105080+openscript@users.noreply.github.com> Date: Fri Mar 17 14:35:56 2023 +0100 Set up continuous deployment for ide-extension (#446) * chore: enable tests * chore: name core publish flow * chore: add publish workflow for ide-extension * chore: format * chore: remove ovsx and adjust vsce token name * chore: enhance package naming * chore: enhance prepare package script commit 2983569 Author: Nils Jacobsen <58360188+NilsJacobsen@users.noreply.github.com> Date: Thu Mar 16 07:36:22 2023 +0100 Text fixes (#449) * index changes after initial pull * feat: add folderstructure for sections #416 * setup landingpage structure * feat: add Section Wrapper for landingpage #416 * Test second hero * feat: add slate colors to ds #416 * #416 relocate landingpage files in website/index * feat: add bg grid component wrapper #416 * #416 add button & navigation * fix button type error * feat: add hero layout #416 * feat: add credibilty section and editor #416 * feat: add vscode extension section and cli section and footer #416 * #416 add useNagition to Button component * #416 add custom header for landingpage * feat: add responsive layout for footer, hero, editor and vscode #316 * #416 add chevron to Buttons * #416 add responsive GetStarted section * #416 add functions to Button * #416 add signal to toggle CLI section * feat: add responsive cli section * #416 fix menu background * #416 optimize Lighthouse score * #416 fix nav for all pages * #416 update wording * highlighting for copytext * feat: add product videos #416 * fix text & text-width * body text width * fix: editor layout #416 * fix: padding on editor #416 * fix: changes bellong to suggestions of code review #416 * fix: small wording fixes #416 --------- Co-authored-by: NiklasBuchfink <niklas.buchfink@web.de> commit d913ef2 Author: Nils Jacobsen <58360188+NilsJacobsen@users.noreply.github.com> Date: Tue Mar 14 07:04:01 2023 +0100 New landing page (#444) * index changes after initial pull * feat: add folderstructure for sections #416 * setup landingpage structure * feat: add Section Wrapper for landingpage #416 * Test second hero * feat: add slate colors to ds #416 * #416 relocate landingpage files in website/index * feat: add bg grid component wrapper #416 * #416 add button & navigation * fix button type error * feat: add hero layout #416 * feat: add credibilty section and editor #416 * feat: add vscode extension section and cli section and footer #416 * #416 add useNagition to Button component * #416 add custom header for landingpage * feat: add responsive layout for footer, hero, editor and vscode #316 * #416 add chevron to Buttons * #416 add responsive GetStarted section * #416 add functions to Button * #416 add signal to toggle CLI section * feat: add responsive cli section * #416 fix menu background * #416 optimize Lighthouse score * #416 fix nav for all pages * #416 update wording * highlighting for copytext * feat: add product videos #416 * fix text & text-width * body text width * fix: editor layout #416 * fix: padding on editor #416 * fix: changes bellong to suggestions of code review #416 --------- Co-authored-by: NiklasBuchfink <niklas.buchfink@web.de> commit 6500378 Author: NiklasBuchfink <niklas.buchfink@web.de> Date: Thu Mar 9 15:30:09 2023 +0000 commit e75807a Author: Samuel Stroschein <35429197+samuelstroschein@users.noreply.github.com> Date: Thu Mar 9 13:49:06 2023 +0000 chore: update turborepo Avoiding exec runtime error in docker container. commit 9ddd3da Author: Jannes Blobel <72493222+jannesblobel@users.noreply.github.com> Date: Thu Mar 9 00:10:30 2023 +0100 Update config.md
ivanhofer
pushed a commit
that referenced
this pull request
Mar 28, 2023
* fix: linting errors * chore: add changeset
Contributor
Author
|
@samuelstroschein As I'm in between i18n implementations for a side project of mine (currently using sveltekit-i18n), I could actually look into getting inlang in it and I can document any potential issues I find along the way. |
Member
|
@boian-ivanov expect hickups down the road. sveltekit-i18n should work with inlang-plugin-json |
felixhaeberle
pushed a commit
that referenced
this pull request
Apr 4, 2023
* fix: linting errors * chore: add changeset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I've been looking at some of the PRs with the project, I've noticed some linting errors being shown. This PR cleans them, although with some
// eslint-disablemagic, due to not being completely sure if some of the destructuring in Solid might brake. I'm open to suggestions on how this could be dealt more appropriately