Merged
Conversation
|
|
There was a problem hiding this comment.
Pull request overview
This PR adds first-class HanaDB alerting support to the repository by introducing a new hanadb-alerts Helm chart (PrometheusRule + optional Grafana dashboard import), along with the corresponding HanaDBAlerts API types in apis/alerts/v1alpha1.
Changes:
- Added a new
charts/hanadb-alertschart with alert rules, values, schema, docs, and runbooks. - Added optional Grafana dashboard import via ConfigMap + Job when
grafana.enabled=true. - Introduced
HanaDBAlerts/HanaDBAlertsListAPI types and generated deepcopy + scheme registration.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| charts/hanadb-alerts/Chart.yaml | Declares the new Helm chart metadata/version. |
| charts/hanadb-alerts/values.yaml | Default values for alert toggles, thresholds, and Grafana settings. |
| charts/hanadb-alerts/values.openapiv3_schema.yaml | Values schema for Helm UI/validation. |
| charts/hanadb-alerts/templates/_helpers.tpl | Standard helper templates for labels and enablement logic. |
| charts/hanadb-alerts/templates/alert.yaml | PrometheusRule definitions for HanaDB database + provisioner alerts. |
| charts/hanadb-alerts/templates/configmap.yaml | Grafana dashboard JSON embedded in a ConfigMap (conditional). |
| charts/hanadb-alerts/templates/job.yaml | Job to POST the dashboard to Grafana (conditional). |
| charts/hanadb-alerts/crds/monitoring.coreos.com_prometheusrules.yaml | PrometheusRule CRD shipped with the chart. |
| charts/hanadb-alerts/README.md | Installation and configuration documentation for the new chart. |
| charts/hanadb-alerts/doc.yaml | Chart documentation metadata for the docs system. |
| charts/hanadb-alerts/remedy.md | Runbook/remediation guidance for the added alerts. |
| charts/hanadb-alerts/ticket-template.md | Support ticket data collection template. |
| charts/hanadb-alerts/.helmignore | Standard Helm ignore patterns. |
| apis/alerts/v1alpha1/hanadb_alerts_types.go | New CRD API types for HanaDB alerts configuration. |
| apis/alerts/v1alpha1/register.go | Registers the new types with the scheme. |
| apis/alerts/v1alpha1/zz_generated.deepcopy.go | Generated deepcopy implementations for the new types. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Neaj-Morshad-101
requested changes
Apr 2, 2026
ZobayerAbedin
force-pushed
the
hdb-monitoring
branch
2 times, most recently
from
ac11a60 to
cd62bef
Compare
Neaj-Morshad-101
requested changes
Apr 8, 2026
Signed-off-by: ZobayerAbedin <zobayerabedin@gmail.com>
Signed-off-by: ZobayerAbedin <zobayerabedin@gmail.com>
* Add Milvus Alerts Signed-off-by: urmi <urmi@appscode.com> * fix readme Signed-off-by: urmi <urmi@appscode.com> --------- Signed-off-by: urmi <urmi@appscode.com> Signed-off-by: ZobayerAbedin <zobayerabedin@gmail.com>
ZobayerAbedin
force-pushed
the
hdb-monitoring
branch
from
55659b5 to
7d20234
Compare
Signed-off-by: ZobayerAbedin <zobayerabedin@gmail.com>
ZobayerAbedin
force-pushed
the
hdb-monitoring
branch
from
7d20234 to
ab0ccb8
Compare
Neaj-Morshad-101
approved these changes
Apr 10, 2026
souravbiswassanto
added
the
automerge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.