fix(ctl): let typer.Exit propagate so CLI commands exit without a traceback#1048
Draft
ogenstad wants to merge 1 commit into
Draft
fix(ctl): let typer.Exit propagate so CLI commands exit without a traceback#1048ogenstad wants to merge 1 commit into
ogenstad wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
@@ Coverage Diff @@
## stable #1048 +/- ##
==========================================
- Coverage 81.54% 74.41% -7.14%
==========================================
Files 134 134
Lines 11468 11469 +1
Branches 1735 1734 -1
==========================================
- Hits 9352 8535 -817
- Misses 1569 2392 +823
+ Partials 547 542 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 34 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Newer versions of typer behave differently and produce an error that's not as friendly as we'd want and we don't want to show that error.
Closes #1047
What changed
Summary by cubic
Fixes
infrahubctlso commands that raisetyper.Exitexit cleanly without the "Error: 1" line or a traceback. Addresses IHS-237 by ensuringinfrahubctl schema loadprints only the human-readable error and exits with code 1.typer.Exitpropagate incatch_exception(sync and async) so Typer handles the exit without a traceback.click.exceptions.Exitfromhandle_exception.Written for commit 712ffcf. Summary will update on new commits.
Review in cubic