Skip to content

Conversation

@dgarros
Copy link
Contributor

@dgarros dgarros commented Jan 1, 2025

Fixes #191

Disable by default the inclusion of properties for Attribute and Relationships when querying nodes from Infrahub.
The inclusion of properties can be enabled by using the parameter property in client.get|all|filters

@codecov
Copy link

codecov bot commented Jan 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

@@             Coverage Diff             @@
##           develop     #199      +/-   ##
===========================================
+ Coverage    66.31%   66.36%   +0.04%     
===========================================
  Files           81       81              
  Lines         7253     7257       +4     
  Branches      1409     1412       +3     
===========================================
+ Hits          4810     4816       +6     
+ Misses        2060     2058       -2     
  Partials       383      383              
Flag Coverage Δ
integration-tests 7.15% <7.14%> (-0.06%) ⬇️
python-3.10 43.72% <89.28%> (+0.05%) ⬆️
python-3.11 43.72% <89.28%> (+0.05%) ⬆️
python-3.12 43.72% <89.28%> (+0.05%) ⬆️
python-3.13 43.72% <89.28%> (+0.05%) ⬆️
python-3.9 42.13% <89.28%> (+0.05%) ⬆️
python-filler-3.12 24.45% <10.71%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/client.py 63.69% <ø> (ø)
infrahub_sdk/node.py 72.07% <100.00%> (+0.30%) ⬆️

... and 1 file with indirect coverage changes

@dgarros dgarros marked this pull request as ready for review January 1, 2025 18:02
@dgarros dgarros requested a review from a team January 1, 2025 18:02
@dgarros dgarros force-pushed the dga-20250101-property branch from af27e6a to 9c87b10 Compare January 2, 2025 13:31
@dgarros dgarros merged commit 322a0d1 into develop Jan 2, 2025
14 checks passed
@dgarros dgarros deleted the dga-20250101-property branch January 2, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feature: Add flag to control the usage or not of property

3 participants