Fix regression with Node update #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## stable #212 +/- ##
==========================================
+ Coverage 67.79% 68.03% +0.23%
==========================================
Files 82 82
Lines 7360 7370 +10
Branches 1438 1440 +2
==========================================
+ Hits 4990 5014 +24
+ Misses 1993 1984 -9
+ Partials 377 372 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dgarros
force-pushed
the
dga-20250105-fix-update
branch
4 times, most recently
from
0c1770d to
eda56dc
Compare
dgarros
force-pushed
the
dga-20250105-fix-update
branch
from
eda56dc to
b454b92
Compare
ajtmccarty
approved these changes
Jan 5, 2025
Contributor
ajtmccarty
left a comment
ajtmccarty
left a comment
There was a problem hiding this comment.
2 "you can do it if you want to" comments and one commented-out line that can maybe be removed
| # assert sorted([tag.peer_id for tag in tags]) == sorted([tag_green.id, tag_blue.id]) | ||
| car3 = await client.get(kind=TESTING_CAR, id=car_golf.id) | ||
| await car3.tags.fetch() | ||
| assert sorted([tag.id for tag in car3.tags.peers]) == sorted([tag_green.id, tag_blue.id]) |
Contributor
There was a problem hiding this comment.
you can use sets for these instead of sorting
Contributor
Author
There was a problem hiding this comment.
Indeed, not sure how i missed that, I'll fix in another PR
dgarros
force-pushed
the
dga-20250105-fix-update
branch
from
0b9c723 to
2423449
Compare
dgarros
force-pushed
the
dga-20250105-fix-update
branch
from
2423449 to
64b5dff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue introduced by #199 that would prevent a node with relationship of cardinality one from being updated.
As a workaround, it's recommended to enable the property when querying the object (property=True)
This is good reminder that :
_strip_unmodified)I've also included the RN and the version upgrade to 1.4.1 in this PR