Skip to content

Conversation

@dgarros
Copy link
Contributor

@dgarros dgarros commented Jan 1, 2025

Implement PEP 604 with future annotations to support Python 3.9
https://docs.astral.sh/ruff/rules/non-pep604-annotation/

@codecov
Copy link

codecov bot commented Jan 1, 2025

Codecov Report

Attention: Patch coverage is 21.29870% with 303 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
infrahub_sdk/schema/main.py 0.00% 48 Missing ⚠️
infrahub_sdk/node.py 30.64% 43 Missing ⚠️
infrahub_sdk/protocols_base.py 0.00% 30 Missing ⚠️
infrahub_sdk/store.py 0.00% 14 Missing ⚠️
infrahub_sdk/config.py 7.14% 13 Missing ⚠️
infrahub_sdk/exceptions.py 0.00% 13 Missing ⚠️
infrahub_sdk/task_report.py 0.00% 13 Missing ⚠️
infrahub_sdk/schema/__init__.py 0.00% 11 Missing ⚠️
infrahub_sdk/batch.py 0.00% 9 Missing ⚠️
infrahub_sdk/pytest_plugin/models.py 20.00% 8 Missing ⚠️
... and 26 more

❗ There is a different number of reports uploaded between BASE (5011dbf) and HEAD (8aaec9a). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (5011dbf) HEAD (8aaec9a)
python-filler-3.12 1 0
@@             Coverage Diff              @@
##           develop     #203       +/-   ##
============================================
- Coverage    66.33%   44.56%   -21.78%     
============================================
  Files           81       81               
  Lines         7259     7253        -6     
  Branches      1409     1407        -2     
============================================
- Hits          4815     3232     -1583     
- Misses        2059     3724     +1665     
+ Partials       385      297       -88     
Flag Coverage Δ
integration-tests 7.21% <7.27%> (+<0.01%) ⬆️
python-3.10 43.66% <21.29%> (-0.04%) ⬇️
python-3.11 43.66% <21.29%> (-0.04%) ⬇️
python-3.12 43.66% <21.29%> (-0.04%) ⬇️
python-3.13 43.66% <21.29%> (-0.04%) ⬇️
python-3.9 42.07% <21.29%> (-0.73%) ⬇️
python-filler-3.12 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/ctl/check.py 27.04% <100.00%> (-1.18%) ⬇️
infrahub_sdk/ctl/cli_commands.py 45.17% <100.00%> (ø)
infrahub_sdk/ctl/client.py 50.00% <100.00%> (+2.38%) ⬆️
infrahub_sdk/ctl/config.py 64.70% <100.00%> (ø)
infrahub_sdk/ctl/exporter.py 50.00% <ø> (-2.18%) ⬇️
infrahub_sdk/ctl/generator.py 23.21% <100.00%> (ø)
infrahub_sdk/ctl/repository.py 73.58% <100.00%> (ø)
infrahub_sdk/ctl/schema.py 55.83% <100.00%> (ø)
infrahub_sdk/ctl/utils.py 66.42% <100.00%> (ø)
infrahub_sdk/ctl/validate.py 52.85% <100.00%> (ø)
... and 44 more

... and 9 files with indirect coverage changes

@dgarros dgarros marked this pull request as ready for review January 1, 2025 18:01
@dgarros dgarros requested a review from a team January 1, 2025 18:02
@dgarros dgarros force-pushed the dga-20250101-pep-604 branch from 5779bed to ac2bae6 Compare January 2, 2025 12:42
@dgarros dgarros force-pushed the dga-20250101-pep-604 branch from ac2bae6 to 8aaec9a Compare January 2, 2025 12:42
@dgarros dgarros merged commit 71ad928 into develop Jan 2, 2025
14 checks passed
@dgarros dgarros deleted the dga-20250101-pep-604 branch January 2, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants