resolves #159: Add batch argument to fetch data in batches #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #219 +/- ##
===========================================
+ Coverage 68.03% 68.21% +0.17%
===========================================
Files 82 82
Lines 7384 7424 +40
Branches 1442 1446 +4
===========================================
+ Hits 5024 5064 +40
Misses 1986 1986
Partials 374 374
Flags with carried forward coverage won't be shown. Click here to find out more.
|
minitriga
changed the title
dgarros
approved these changes
Jan 8, 2025
infrahub_sdk/client.py
Outdated
| nodes = [] | ||
| related_nodes = [] | ||
| batch_process = await self.create_batch() | ||
| resp = await self.execute_graphql(query=f"query {{ {schema_kind} {{ count }} }}") |
Contributor
There was a problem hiding this comment.
Would be good to move this into a dedicated count method, there's already an issue to track that #158
Contributor
Contributor
Author
There was a problem hiding this comment.
I have now moved it over to using client.count().
infrahub_sdk/client.py
Outdated
| prefetch_relationships: bool = ..., | ||
| partial_match: bool = ..., | ||
| property: bool = ..., | ||
| batch: bool = ..., |
Contributor
There was a problem hiding this comment.
Thinking out loud
I'm not sure if batch will be clear enough for the end user ?
As an alternative we could use parallel
any preference @opsmill/customer-success ?
Contributor
Author
There was a problem hiding this comment.
I have renamed to parallel for now.
dgarros
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #159