Skip to content

Conversation

@wvandeun
Copy link
Contributor

#239 should have targeted the stable branch, but targeted develop intead. Due to this the v1.6.0 tag was pushed to the latest commit on stable and we published an incorrect 1.6.0 package to PyPi.

This PR merges the changes into stable, and bumps the version to 1.6.1, so that we can release a new 1.6.1 package to PyPi containing the right changes.

ogenstad and others added 20 commits January 9, 2025 14:04
Avoid providing a falsy fallback to `dict.get()`
* resolves #130: Replace GitPython with dulwich

* Remove debugging

* Add better testing for initializing git repos

* Refactor RepoManager

* Add integration test for dulwich

* Add minimum version for dulwich

* Fix linting for exception match

* Add debug for ci

* Move asserts so it fails early

* Add debugging for integration test

* Return docker compose config in CI

* Add more debugs for files

* Run command on docker host

* Get container logs

* Comment out integration test for git repo

* Remove print
…nt-method

Add possibility to use filters in the SDK client's count method
…query

fix issue with batch execution of queries not considering filters
Replace `Literal[None]` with `None`
# Conflicts:
#	infrahub_sdk/task_report.py
* v1.6 prep
@github-actions github-actions bot added the group/ci Issue related to the CI pipeline label Jan 16, 2025
@codecov
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 90.56604% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
infrahub_sdk/generator.py 33.33% 2 Missing ⚠️
infrahub_sdk/checks.py 66.66% 1 Missing ⚠️
infrahub_sdk/testing/repository.py 90.90% 0 Missing and 1 partial ⚠️
infrahub_sdk/utils.py 80.00% 1 Missing ⚠️
@@            Coverage Diff             @@
##           stable     #240      +/-   ##
==========================================
+ Coverage   68.70%   70.28%   +1.58%     
==========================================
  Files          82       82              
  Lines        7525     7462      -63     
  Branches     1392     1385       -7     
==========================================
+ Hits         5170     5245      +75     
+ Misses       1981     1842     -139     
- Partials      374      375       +1     
Flag Coverage Δ
integration-tests 22.46% <33.96%> (+9.60%) ⬆️
python-3.10 45.48% <66.03%> (+1.23%) ⬆️
python-3.11 45.48% <66.03%> (+1.23%) ⬆️
python-3.12 45.48% <66.03%> (+1.23%) ⬆️
python-3.13 45.48% <66.03%> (+1.23%) ⬆️
python-3.9 45.48% <66.03%> (+1.23%) ⬆️
python-filler-3.12 24.08% <24.52%> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/analyzer.py 84.52% <100.00%> (ø)
infrahub_sdk/client.py 66.97% <100.00%> (+0.07%) ⬆️
infrahub_sdk/node.py 77.58% <100.00%> (ø)
infrahub_sdk/pytest_plugin/items/base.py 64.86% <ø> (+2.36%) ⬆️
infrahub_sdk/repository.py 100.00% <100.00%> (ø)
infrahub_sdk/transforms.py 70.21% <100.00%> (ø)
infrahub_sdk/checks.py 70.19% <66.66%> (ø)
infrahub_sdk/testing/repository.py 77.77% <90.90%> (+77.77%) ⬆️
infrahub_sdk/utils.py 78.00% <80.00%> (+1.23%) ⬆️
infrahub_sdk/generator.py 35.52% <33.33%> (ø)

@wvandeun wvandeun self-assigned this Jan 16, 2025
@lykinsbd lykinsbd merged commit dbbe385 into stable Jan 17, 2025
14 checks passed
@lykinsbd lykinsbd deleted the wvd-release-1.6.1 branch January 17, 2025 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

group/ci Issue related to the CI pipeline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants