-
Notifications
You must be signed in to change notification settings - Fork 6
Remove default value "main" for branch parameter from all Infrahub CTL commands #270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## stable #270 +/- ##
==========================================
- Coverage 70.36% 70.34% -0.03%
==========================================
Files 82 82
Lines 7502 7502
Branches 1391 1391
==========================================
- Hits 5279 5277 -2
- Misses 1849 1850 +1
- Partials 374 375 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, wonder if there isn't more to do on the rest of the SDK as well
|
@wvandeun @BaptisteGi are we good to merge this PR ? |
…TL commands (#270) * Remove default value main for branch parameter * Changelog * Remove branch parameter from repository commands as node is branch agnostic * Add None for username * Remove branch parameter from tests * Remove branch parameter from test * Add option to list repository by branch * Adjust parameter help
Before (env variable is ignored):
After (Take into account the env variable + If there is no default branch set then fallback on default branch set in SDK):
resolves: #264