Fix typing for Python 3.9 and remove support for Python 3.13 #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgarros
force-pushed
the
dga-20250130-fix-253
branch
from
931ef1d to
3782d1c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## stable #259 +/- ##
==========================================
+ Coverage 70.31% 70.33% +0.02%
==========================================
Files 81 81
Lines 7502 7505 +3
Branches 1391 1463 +72
==========================================
+ Hits 5275 5279 +4
+ Misses 1852 1847 -5
- Partials 375 379 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dgarros
force-pushed
the
dga-20250130-fix-253
branch
2 times, most recently
from
0ad5dc9 to
304dfe5
Compare
dgarros
force-pushed
the
dga-20250130-fix-253
branch
from
951face to
a19d50d
Compare
ogenstad
approved these changes
Feb 20, 2025
There was a problem hiding this comment.
LGTM. I wonder if it's fixed in later versions of Typer. We have it pinned to 0.12.5 in the lock file and with the typer = { version = "^0.12.3", optional = true } since it's below 1.0 we don't actually support the newer 0.13, 0.14 and 0.15 versions of Typer.
pyproject.toml
Outdated
| ] | ||
|
|
||
| "infrahub_sdk/ctl/**/*.py" = [ | ||
| "UP007", # Use `X | Y` for type annotations |
There was a problem hiding this comment.
If this was only related to Typer can you add this as a comment to indicate why we have this?
There was a problem hiding this comment.
Good point, I added a comment
Regarding Typer 0.15, I tried but the issue was still present
dgarros
force-pushed
the
dga-20250130-fix-253
branch
from
a19d50d to
b61ea64
Compare
dgarros
force-pushed
the
dga-20250130-fix-253
branch
from
b61ea64 to
1aa09f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #251
Fixes #253
This PR removes the support for Python 3.13 and fixes the typing issues for
infrahubctlfor Python 3.9 by reverting to the old annotation (Optional).The root cause of the issue seams to be with Typer that doesn't support this format prior to 3.10.
Also, this PR implement the fix proposed in #250 by @FragmentedPacket to ensure the tests are running with the right version of Python in CI.