Skip to content

Conversation

@ogenstad
Copy link
Contributor

@ogenstad ogenstad commented Nov 18, 2025

Disallow adding additional shadows for builtins, fix a case where we were shadowing dir, added the other known ones to an ignore list for now.

@coderabbitai
Copy link

coderabbitai bot commented Nov 18, 2025

Warning

Rate limit exceeded

@ogenstad has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 27 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 21d565e and 38ac489.

📒 Files selected for processing (2)
  • pyproject.toml (1 hunks)
  • tests/unit/sdk/test_yaml.py (1 hunks)
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch pog-ruff-builtin-filter-infrahub-develop-20251118

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                Coverage Diff                @@
##           infrahub-develop     #645   +/-   ##
=================================================
  Coverage             75.56%   75.56%           
=================================================
  Files                   113      113           
  Lines                  9514     9514           
  Branches               1448     1448           
=================================================
  Hits                   7189     7189           
  Misses                 1838     1838           
  Partials                487      487           
Flag Coverage Δ
integration-tests 34.96% <ø> (ø)
python-3.10 48.88% <ø> (+0.02%) ⬆️
python-3.11 48.88% <ø> (+0.02%) ⬆️
python-3.12 48.84% <ø> (-0.03%) ⬇️
python-3.13 48.86% <ø> (+0.02%) ⬆️
python-3.9 48.86% <ø> (+0.02%) ⬆️
python-filler-3.12 24.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ogenstad ogenstad force-pushed the pog-ruff-builtin-filter-infrahub-develop-20251118 branch from a172c33 to 38ac489 Compare November 19, 2025 07:01
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 19, 2025

Deploying infrahub-sdk-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: 38ac489
Status: ✅  Deploy successful!
Preview URL: https://283d5ef0.infrahub-sdk-python.pages.dev
Branch Preview URL: https://pog-ruff-builtin-filter-infr.infrahub-sdk-python.pages.dev

View logs

@ogenstad ogenstad marked this pull request as ready for review November 19, 2025 07:24
@ogenstad ogenstad requested a review from a team November 19, 2025 07:44
@ogenstad ogenstad merged commit 8483c5a into infrahub-develop Nov 19, 2025
20 checks passed
@ogenstad ogenstad deleted the pog-ruff-builtin-filter-infrahub-develop-20251118 branch November 19, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants