Skip to content

Conversation

@ogenstad
Copy link
Contributor

@ogenstad ogenstad commented Nov 28, 2025

Summary by CodeRabbit

  • Chores

    • Added official Python 3.14 support and updated CI to test it.
    • Bumped a runtime dependency to a newer compatible release.
  • Tests

    • Updated unit tests to align with revised datetime parsing/formatting behavior.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Nov 28, 2025

Walkthrough

This PR adds Python 3.14 support and updates the whenever dependency to >=0.9.3,<0.10.0. The timestamp module replaces LocalDateTime with PlainDateTime and switches parsing calls from parse_common_iso to parse_iso for ZonedDateTime, Instant, PlainDateTime, OffsetDateTime, and Date. Tests and test utilities were updated to reflect API changes (Instant.instant renamed to Instant.to_instant, Instant.parse_common_iso → parse_iso) and formatting calls changed from format_common_iso to format_iso.

Pre-merge checks

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Title check ❓ Inconclusive The title 'Python 3.14' is vague and generic, using non-descriptive phrasing that doesn't convey the specific nature of the changes made. Consider a more descriptive title such as 'Add Python 3.14 support and update whenever dependency' or 'Support Python 3.14 and upgrade datetime parsing' to better reflect the actual scope of changes.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7dbe178 and 632eed1.

📒 Files selected for processing (1)
  • changelog/+b4648cfa.added.md (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: unit-tests (3.10)
  • GitHub Check: unit-tests (3.11)
  • GitHub Check: unit-tests (3.13)
  • GitHub Check: unit-tests (3.14)
  • GitHub Check: unit-tests (3.12)
  • GitHub Check: Cloudflare Pages
🔇 Additional comments (1)
changelog/+b4648cfa.added.md (1)

1-1: Changelog entry is clear and accurate. The entry appropriately documents the addition of Python 3.14 support at the right level of detail for a changelog.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the group/ci Issue related to the CI pipeline label Nov 28, 2025
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 28, 2025

Deploying infrahub-sdk-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: 632eed1
Status: ✅  Deploy successful!
Preview URL: https://e02e5c1e.infrahub-sdk-python.pages.dev
Branch Preview URL: https://pog-python-3-14.infrahub-sdk-python.pages.dev

View logs

@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@             Coverage Diff             @@
##           develop     #663      +/-   ##
===========================================
+ Coverage    75.56%   76.01%   +0.44%     
===========================================
  Files          113      113              
  Lines         9512     9742     +230     
  Branches      1448     1490      +42     
===========================================
+ Hits          7188     7405     +217     
- Misses        1837     1841       +4     
- Partials       487      496       +9     
Flag Coverage Δ
integration-tests 34.61% <0.00%> (-0.35%) ⬇️
python-3.10 49.94% <85.71%> (+1.09%) ⬆️
python-3.11 49.94% <85.71%> (+1.07%) ⬆️
python-3.12 49.92% <85.71%> (+1.07%) ⬆️
python-3.13 49.90% <85.71%> (+1.07%) ⬆️
python-3.14 51.58% <85.71%> (?)
python-3.9 ?
python-filler-3.12 23.94% <14.28%> (-0.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/timestamp.py 82.88% <100.00%> (-0.91%) ⬇️

... and 14 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Fatih Acar <fatih@opsmill.com>
@ogenstad
Copy link
Contributor Author

ogenstad commented Dec 8, 2025

Thanks @fatih-acar, we'd want to have a pipeline against the Infrahub repo as a test that includes this PR. The whenever package is also pinned in Infrahub and used directly in a small number of places. Could be that we don't need to update the code there but would be nice to verify.

@fatih-acar
Copy link
Contributor

I've done it in opsmill/infrahub#7746
But I can do a separate PR containing only the SDK update?

@ogenstad
Copy link
Contributor Author

ogenstad commented Dec 8, 2025

I've done it in opsmill/infrahub#7746 But I can do a separate PR containing only the SDK update?

I don't think a separate one is required. As long as we see that it doesn't break anything. Then once this PR is merged we should update the infrahub develop branch to use the latest infrahub-develop from the SDK.

@fatih-acar fatih-acar changed the base branch from infrahub-develop to develop December 9, 2025 09:28
@fatih-acar fatih-acar marked this pull request as ready for review December 9, 2025 09:28
@ogenstad ogenstad requested a review from a team December 9, 2025 12:37
@ogenstad ogenstad merged commit f739954 into develop Dec 9, 2025
21 checks passed
@ogenstad ogenstad deleted the pog-python-3.14 branch December 9, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

group/ci Issue related to the CI pipeline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants