-
Notifications
You must be signed in to change notification settings - Fork 7
Python 3.14 #663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.14 #663
Conversation
WalkthroughThis PR adds Python 3.14 support and updates the whenever dependency to >=0.9.3,<0.10.0. The timestamp module replaces LocalDateTime with PlainDateTime and switches parsing calls from parse_common_iso to parse_iso for ZonedDateTime, Instant, PlainDateTime, OffsetDateTime, and Date. Tests and test utilities were updated to reflect API changes (Instant.instant renamed to Instant.to_instant, Instant.parse_common_iso → parse_iso) and formatting calls changed from format_common_iso to format_iso. Pre-merge checks❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying infrahub-sdk-python with
|
| Latest commit: |
632eed1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e02e5c1e.infrahub-sdk-python.pages.dev |
| Branch Preview URL: | https://pog-python-3-14.infrahub-sdk-python.pages.dev |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## develop #663 +/- ##
===========================================
+ Coverage 75.56% 76.01% +0.44%
===========================================
Files 113 113
Lines 9512 9742 +230
Branches 1448 1490 +42
===========================================
+ Hits 7188 7405 +217
- Misses 1837 1841 +4
- Partials 487 496 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 14 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Signed-off-by: Fatih Acar <fatih@opsmill.com>
31bfed8 to
7dbe178
Compare
|
Thanks @fatih-acar, we'd want to have a pipeline against the Infrahub repo as a test that includes this PR. The |
|
I've done it in opsmill/infrahub#7746 |
I don't think a separate one is required. As long as we see that it doesn't break anything. Then once this PR is merged we should update the infrahub develop branch to use the latest |
Summary by CodeRabbit
Chores
Tests
✏️ Tip: You can customize this high-level summary in your review settings.