Skip to content

Conversation

@infrahub-github-bot-app
Copy link
Contributor

Merging develop into infrahub-develop after merging pull request #749.

* IHS-183: Fix typing errors for protocols

* fix ty

* fix failing tests

* address comments
@coderabbitai
Copy link

coderabbitai bot commented Jan 21, 2026

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

@cloudflare-workers-and-pages
Copy link

Deploying infrahub-sdk-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6c0bf35
Status: ✅  Deploy successful!
Preview URL: https://9a52283f.infrahub-sdk-python.pages.dev
Branch Preview URL: https://develop.infrahub-sdk-python.pages.dev

View logs

@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

❌ Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
infrahub_sdk/schema/__init__.py 33.33% 1 Missing and 1 partial ⚠️
@@                 Coverage Diff                  @@
##           infrahub-develop     #752      +/-   ##
====================================================
+ Coverage             80.30%   80.35%   +0.05%     
====================================================
  Files                   115      115              
  Lines                  9874     9872       -2     
  Branches               1518     1512       -6     
====================================================
+ Hits                   7929     7933       +4     
  Misses                 1417     1417              
+ Partials                528      522       -6     
Flag Coverage Δ
integration-tests 41.30% <18.75%> (+<0.01%) ⬆️
python-3.10 50.92% <18.75%> (+0.01%) ⬆️
python-3.11 50.92% <18.75%> (-0.01%) ⬇️
python-3.12 50.92% <18.75%> (+0.03%) ⬆️
python-3.13 50.92% <18.75%> (+0.03%) ⬆️
python-3.14 52.56% <18.75%> (+0.03%) ⬆️
python-filler-3.12 24.07% <68.75%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/ctl/branch.py 81.13% <ø> (ø)
infrahub_sdk/node/related_node.py 92.44% <100.00%> (ø)
infrahub_sdk/protocols_base.py 78.22% <100.00%> (+4.21%) ⬆️
infrahub_sdk/testing/repository.py 77.77% <ø> (ø)
infrahub_sdk/schema/__init__.py 69.42% <33.33%> (+0.08%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@solababs solababs merged commit d619c6f into infrahub-develop Jan 21, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants