Avoid + operator to concatenate collections#826
Conversation
|
No actionable comments were generated in the recent review. 🎉 WalkthroughThis pull request refactors list construction syntax across multiple files in the infrahub\_sdk package. List concatenation operations using the \+ operator are replaced with unpacking syntax using the \* operator. Changes are made in node.py, protocols\_generator.py, spec/object.py, topological\_sort.py, and utils.py. Additionally, the RUF005 rule is removed from the Ruff ignore list in pyproject.toml to enforce this syntactic pattern. The functional behavior and control flow remain unchanged across all modifications. 🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## infrahub-develop #826 +/- ##
====================================================
+ Coverage 80.57% 80.59% +0.01%
====================================================
Files 118 118
Lines 10235 10235
Branches 1538 1538
====================================================
+ Hits 8247 8249 +2
+ Misses 1457 1456 -1
+ Partials 531 530 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Why
Minor linting fix to remove rule from exceptions
What changed
Avoid + operator to concatenate collections and instead use a single collection, probably trivial performance gains.
Summary by CodeRabbit