Skip to content

Merge 'develop' into 'infrahub-develop'#926

Merged
ogenstad merged 10 commits intoinfrahub-developfrom
develop
Apr 8, 2026
Merged

Merge 'develop' into 'infrahub-develop'#926
ogenstad merged 10 commits intoinfrahub-developfrom
develop

Conversation

@ogenstad
Copy link
Copy Markdown
Contributor

@ogenstad ogenstad commented Apr 8, 2026

Why

Bring in latest changes from develop

What changed

  • All commits from develop

Summary by CodeRabbit

  • Bug Fixes

    • Fixed protocol generation: optional attributes with default values now render as required instead of nullable.
  • Tests

    • Added comprehensive test coverage for attribute rendering logic.
  • Chores

    • Updated GitHub Actions labeler version and extended integration test timeout.

dependabot bot and others added 6 commits March 2, 2026 09:13
Bumps [crazy-max/ghaction-github-labeler](https://github.com/crazy-max/ghaction-github-labeler) from 5 to 6.
- [Release notes](https://github.com/crazy-max/ghaction-github-labeler/releases)
- [Commits](crazy-max/ghaction-github-labeler@v5...v6)

---
updated-dependencies:
- dependency-name: crazy-max/ghaction-github-labeler
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
…/crazy-max/ghaction-github-labeler-6

Bump crazy-max/ghaction-github-labeler from 5 to 6
Merge stable into develop
@github-actions github-actions bot added the group/ci Issue related to the CI pipeline label Apr 8, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 8, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: cf8b1466-2098-4c6f-9145-3c112c938856

📥 Commits

Reviewing files that changed from the base of the PR and between 2e87b74 and 95ceea8.

📒 Files selected for processing (9)
  • .github/workflows/ci.yml
  • .github/workflows/labels.yml
  • changelog/894.fixed.md
  • infrahub_sdk/ctl/cli_commands.py
  • infrahub_sdk/ctl/commands/create.py
  • infrahub_sdk/ctl/commands/update.py
  • infrahub_sdk/ctl/formatters/yaml.py
  • infrahub_sdk/protocols_generator/generator.py
  • tests/unit/sdk/test_protocols_generator.py

Walkthrough

This pull request contains multiple improvements across the SDK and CI configuration. It removes type-checker suppression comments from imports in several files, updates workflow configurations (extending CI timeout and upgrading the GitHub labeler action), and modifies protocol generation logic to render optional attributes with default values as required rather than optional. CLI command control flow is adjusted to properly handle the --set argument path, and relationship cardinality comparisons are updated to use enum values instead of string literals. Additionally, comprehensive test coverage is added for the attribute rendering behavior changes.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

❌ Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
infrahub_sdk/ctl/commands/update.py 33.33% 0 Missing and 2 partials ⚠️
infrahub_sdk/ctl/commands/create.py 50.00% 0 Missing and 1 partial ⚠️
@@                 Coverage Diff                  @@
##           infrahub-develop     #926      +/-   ##
====================================================
- Coverage             82.56%   82.56%   -0.01%     
====================================================
  Files                   134      134              
  Lines                 13192    13194       +2     
  Branches               2286     2287       +1     
====================================================
+ Hits                  10892    10893       +1     
  Misses                 1652     1652              
- Partials                648      649       +1     
Flag Coverage Δ
integration-tests 44.92% <73.33%> (-0.01%) ⬇️
python-3.10 56.62% <80.00%> (-0.01%) ⬇️
python-3.11 56.60% <80.00%> (-0.02%) ⬇️
python-3.12 56.62% <80.00%> (-0.01%) ⬇️
python-3.13 56.62% <80.00%> (-0.01%) ⬇️
python-3.14 58.46% <80.00%> (-0.02%) ⬇️
python-filler-3.12 22.65% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/ctl/cli_commands.py 73.02% <100.00%> (ø)
infrahub_sdk/ctl/formatters/yaml.py 87.75% <100.00%> (ø)
infrahub_sdk/protocols_generator/generator.py 94.54% <100.00%> (ø)
infrahub_sdk/ctl/commands/create.py 92.00% <50.00%> (-1.88%) ⬇️
infrahub_sdk/ctl/commands/update.py 75.78% <33.33%> (+0.25%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ogenstad added 4 commits April 8, 2026 15:53
…-IHS-216

Render optional attributes with default values as mandatory
Merge 'stable' into 'develop'
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Apr 8, 2026

Deploying infrahub-sdk-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: 95ceea8
Status: ✅  Deploy successful!
Preview URL: https://68374ef8.infrahub-sdk-python.pages.dev
Branch Preview URL: https://develop.infrahub-sdk-python.pages.dev

View logs

@ogenstad ogenstad marked this pull request as ready for review April 8, 2026 18:08
@ogenstad ogenstad requested a review from a team as a code owner April 8, 2026 18:08
@ogenstad ogenstad merged commit 405b656 into infrahub-develop Apr 8, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

group/ci Issue related to the CI pipeline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant