Skip to content

Show changes to profiles within diff view for PC and branch#8676

Merged
pa-lem merged 27 commits intostablefrom
pog-profile-diff-IFC-2316
Mar 31, 2026
Merged

Show changes to profiles within diff view for PC and branch#8676
pa-lem merged 27 commits intostablefrom
pog-profile-diff-IFC-2316

Conversation

@ogenstad
Copy link
Copy Markdown
Contributor

@ogenstad ogenstad commented Mar 23, 2026

Why

Ensure that changes to profiles show up within the data diff view for proposed changes and profiles

Fixes #8529

What changed

Previously we excluded the Schema and Profile namespace. It makes sense to remove the Schemas from the the data view but we want the Profiles to show up.

Example of screenshot

image

Summary by CodeRabbit

  • Bug Fixes
    • Data diff now includes Profile changes and tab counts reflect those Profile entries (namespace exclusion adjusted).
    • Header badge now shows schema namespace/label when available for clearer item identification.
  • Tests
    • End-to-end assertions updated to match renamed diff item labels in the UI.
  • Chores
    • Added changelog entry documenting the fix.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 23, 2026

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

Walkthrough

The data-diff view was changed to include Profile entries by removing "Profile" from namespace exclusion filters in data-tab, branches/details, and proposed-changes/details. The node-diff header now uses useSchema(node.kind) and derives its badge text from schema.namespace (when present), then schema.label/schema.name, and finally node.kind. A changelog entry was added, .betterer.results TypeScript diagnostic positions were updated, and E2E tests were adjusted for renamed UI text.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title directly describes the main change: showing profile changes in the diff view for proposed changes and branches.
Description check ✅ Passed The description includes Why, What changed, and an example screenshot, covering the essential information though not all optional template sections.
Linked Issues check ✅ Passed All code changes directly address issue #8529 by removing Profile from namespace exclusion filters and updating related badge rendering logic.
Out of Scope Changes check ✅ Passed All changes are scoped to removing Profile namespace exclusion from diff views and updating related components; no unrelated changes detected.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the group/frontend Issue related to the frontend (React) label Mar 23, 2026
@ogenstad ogenstad marked this pull request as ready for review March 23, 2026 15:47
@ogenstad ogenstad requested a review from a team as a code owner March 23, 2026 15:47
@pa-lem pa-lem requested review from a team as code owners March 26, 2026 12:51
@pa-lem pa-lem force-pushed the pog-profile-diff-IFC-2316 branch from 6d9c817 to 507aac1 Compare March 26, 2026 12:52
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@frontend/app/src/entities/proposed-changes/ui/tabs/data-tab.tsx`:
- Line 16: Add regression tests that verify profile-namespace items are shown
and counted in the Data diff: render the DataTab component (DataTab) with a
proposedChanges payload that includes entries under the "profile" namespace (and
ensure Schema entries remain excluded), then assert the profile items are
present in the rendered list and that the Data tab label/count reflects those
items; add one test for list rendering and one for tab count behavior (render
the parent tabs or the component/function that computes tab counts) using the
existing testing-library/Jest patterns so the new inclusion of profile is locked
by tests.

In `@frontend/packages/schema-visualizer`:
- Line 1: The commit added a gitlink for the submodule
frontend/packages/schema-visualizer but did not register it in .gitmodules; add
a [submodule "frontend/packages/schema-visualizer"] entry to .gitmodules
including path = frontend/packages/schema-visualizer and the repository URL for
that submodule (matching the origin used to create the gitlink), then commit the
updated .gitmodules so Git can initialize/update the submodule at commit
8496f057a14c041bcc4ce7a91af2b77a8bd2f17e.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3f4de3f7-0e4d-44b9-8844-351b6cb94f21

📥 Commits

Reviewing files that changed from the base of the PR and between 9e33983 and b869998.

📒 Files selected for processing (6)
  • changelog/8529.fixed.md
  • frontend/app/src/entities/diff/node-diff/node.tsx
  • frontend/app/src/entities/proposed-changes/ui/tabs/data-tab.tsx
  • frontend/app/src/pages/branches/details.tsx
  • frontend/app/src/pages/proposed-changes/details.tsx
  • frontend/packages/schema-visualizer

Comment thread frontend/app/src/entities/proposed-changes/ui/tabs/data-tab.tsx
Comment thread frontend/packages/schema-visualizer Outdated
@pa-lem pa-lem removed request for a team March 26, 2026 15:08
@pa-lem pa-lem merged commit a280f9a into stable Mar 31, 2026
42 checks passed
@pa-lem pa-lem deleted the pog-profile-diff-IFC-2316 branch March 31, 2026 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

group/frontend Issue related to the frontend (React)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Profile changes not shown in proposed changes data diff

3 participants