refactor: replace lambda with operator.itemgetter in query result sorting#8971
Open
refactor: replace lambda with operator.itemgetter in query result sorting#8971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
These two ruff rules (FURB118, FURB140) were previously suppressed. The fixes are straightforward — operator.itemgetter and itertools.starmap are the idiomatic stdlib alternatives when a lambda or comprehension does nothing but unpack and forward arguments to a function. Enabling the rules and fixing the violations reduces the ignore list and keeps the codebase consistent with the rest of the ruff configuration.
What changed
Removed FURB118 and FURB140 from the ruff ignore list in pyproject.toml and fixed all violations.
Summary by cubic
Replaced lambda and manual unpacking with stdlib helpers for clearer code and
ruffcompliance. RemovedFURB118andFURB140from the ignore list and fixed all violations.operator.itemgetter(1)for result sorting inbackend/infrahub/core/query/__init__.py.itertools.starmapto build relationship subqueries inattribute_remove.pyandattribute_rename.py.Written for commit 52843a3. Summary will update on new commits.