Open
Conversation
github-actions
Bot
added
the
group/backend
solababs
force-pushed
the
sb-27042026-fix-typing-for-protocols
branch
from
3a7d899 to
777e628
Compare
ajtmccarty
reviewed
Apr 27, 2026
| @runtime_checkable | ||
| class CoreNode(Protocol): | ||
| class CoreNode: | ||
| _is_runtime_protocol: ClassVar[bool] = True |
Contributor
There was a problem hiding this comment.
does this line actually do anything?
Contributor
Author
There was a problem hiding this comment.
This has been removed
ajtmccarty
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
CoreNodeinprotocols_base.pywas defined as a@runtime_checkable Protocol. Every generated class inprotocols.pyinherits from it, making them Protocol subclasses too. mypy'stype-abstractrule rejects Protocol classes astype[X]arguments — the pattern used throughout the codebase (kind=CoreNumberPool,schema=CoreAccountGroup, etc.)The prior workaround was a blanket
disable_error_code = ["type-abstract"]inpyproject.toml. This PR removes the suppression and fixes the root cause.How to test
uv run invoke backend.mypy # must pass with 0 errors, no type-abstract suppression uv run invoke backend.test-unitChecklist