Skip to content

Sync onechart&cnpg template#1

Merged
poomdech-opsta merged 1 commit intomainfrom
replace-with-onechart
Apr 8, 2026
Merged

Sync onechart&cnpg template#1
poomdech-opsta merged 1 commit intomainfrom
replace-with-onechart

Conversation

@poomdech-opsta
Copy link
Copy Markdown
Contributor

Sync Onechart and CNPG template From onechart repo

@poomdech-opsta poomdech-opsta merged commit bfb8c8c into main Apr 8, 2026
2 checks passed
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Helm charts to version 0.80.0 and the common library to 0.9.0. Key changes include refactoring the cnpg chart to support existing secret lookups and dynamic password generation, adding a new sharedSecretFiles feature to the common library for mounting multiple files from secrets, and simplifying the ServiceAccount template. Documentation and repository indices have been updated accordingly. Feedback highlights a syntax error in the secret-admin-postgres.yaml template where the default function is missing an argument, and suggests restoring standard labels to the ServiceAccount resource for better resource management.

I am having trouble creating individual review comments. Click here to see my feedback.

charts/cnpg/templates/secret-admin-postgres.yaml (8)

high

The default function is used incorrectly here. It requires two arguments: the default value and the input value to evaluate (e.g., {{ .Values.someValue | default "default-value" }}). The current usage {{ default "kubernetes.io/basic-auth" }} is missing the input value and will cause a template rendering error. If the intention was to allow an override, it should likely reference a value like .Values.superuser.type.

charts/common/templates/_serviceaccount.yaml (9-10)

medium

The labels have been removed from the ServiceAccount resource. It is a best practice to include standard labels on all Kubernetes resources to support consistent resource management, filtering, and observability. Consider restoring them using the current helper (e.g., helm-chart.labels).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant