update repo #13
Merged
update repo #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This code is incorrect. I want to support multiple ssh_keys that I can add manually AND support ec2 instance connect. Please redo this. |
abhiyerra
requested changes
May 14, 2022
main.tf
Outdated
| "Effect": "Allow", | ||
| "Action": "ec2:DescribeInstances", | ||
| "Resource": [ | ||
| "arn:aws:ec2:us-east-1:${data.aws_caller_identity.current.account_id}:instance/${aws_instance.x.id}" |
Member
There was a problem hiding this comment.
We should just pass the resources directly as they can be in different environments.
variables.tf
Outdated
|
|
||
| variable "ingress_cidrs" {} | ||
|
|
||
| variable "ec2_connect_installed" { |
Member
There was a problem hiding this comment.
Change this to: ec2_connect_enabled
variables.tf
Outdated
| default = [] | ||
| variable "ssh_key" { | ||
| description = "SSH public key to add to the image" | ||
| default = "" |
Member
There was a problem hiding this comment.
This should be multiple SSH keys. Why is this modified?
README.md
Outdated
| module "bastion" { | ||
| source = "github.com/opszero/terraform-aws-bastion" | ||
|
|
||
| ssh_key = "ssh-rsa ..." |
Member
There was a problem hiding this comment.
This should still support multiple ssh-keys. Why did you remove this feature?
| # Keys | ||
| touch /home/ubuntu/.ssh/authorized_keys | ||
| echo "${ssh_key}" >> /home/ubuntu/.ssh/authorized_keys | ||
| %{endfor~} |
Member
There was a problem hiding this comment.
This needs to still support multiple ssh keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.