Give AphrontTagView a getViewer(), deprecate getUser()

Summary:
Two minor changes here:

  - Replace `get/setUser()` with `get/setViewer()` for consistency with everything else.
  - `getViewer()` now throws if no viewer is set. We had a lot of code that either "should" check this but didn't, or did check it in an identical way, duplicating work. In contrast, very little code checks for a viewer but works if one is not present.

Test Plan:
  - Grepped for `->user`.
  - Attempted to fix all callsites inside `*View` classes.
  - Browsed around a bunch of applications, particularly Calendar, Differential and Diffusion, which seemed most heavily affected.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D15412

Author: epriestley

src/applications/badges/view/PhabricatorBadgesRecipientsListView.php

@@ -16,8 +16,7 @@ public function setHandles(array $handles) {
   }
 
   public function render() {
-
-    $viewer = $this->user;
+    $viewer = $this->getViewer();
 
     $badge = $this->badge;
     $handles = $this->handles;

src/applications/daemon/view/PhabricatorDaemonLogEventsView.php

@@ -24,12 +24,9 @@ public function setCombinedLog($is_combined) {
   }
 
   public function render() {
+    $viewer = $this->getViewer();
     $rows = array();
 
-    if (!$this->user) {
-      throw new PhutilInvalidStateException('setUser');
-    }
-
     foreach ($this->events as $event) {
 
       // Limit display log size. If a daemon gets stuck in an output loop this
@@ -83,8 +80,8 @@ public function render() {
 
       $row = array(
         $event->getLogType(),
-        phabricator_date($event->getEpoch(), $this->user),
-        phabricator_time($event->getEpoch(), $this->user),
+        phabricator_date($event->getEpoch(), $viewer),
+        phabricator_time($event->getEpoch(), $viewer),
         array(
           $message,
           $more,

src/applications/daemon/view/PhabricatorDaemonLogListView.php

@@ -11,11 +11,9 @@ public function setDaemonLogs(array $daemon_logs) {
   }
 
   public function render() {
-    $rows = array();
+    $viewer = $this->getViewer();
 
-    if (!$this->user) {
-      throw new PhutilInvalidStateException('setUser');
-    }
+    $rows = array();
 
     $list = new PHUIObjectItemListView();
     $list->setFlush(true);
@@ -27,7 +25,7 @@ public function render() {
         ->setObjectName(pht('Daemon %s', $id))
         ->setHeader($log->getDaemon())
         ->setHref("/daemon/log/{$id}/")
-        ->addIcon('none', phabricator_datetime($epoch, $this->user));
+        ->addIcon('none', phabricator_datetime($epoch, $viewer));
 
       $status = $log->getStatus();
       switch ($status) {

src/applications/differential/view/DifferentialAddCommentView.php

@@ -50,6 +50,7 @@ public function setCCs(array $names) {
   }
 
   public function render() {
+    $viewer = $this->getViewer();
 
     $this->requireResource('differential-revision-add-comment-css');
     $revision = $this->revision;
@@ -73,7 +74,7 @@ public function render() {
     $form = new AphrontFormView();
     $form
       ->setWorkflow(true)
-      ->setUser($this->user)
+      ->setViewer($viewer)
       ->setAction($this->actionURI)
       ->addHiddenInput('revision_id', $revision->getID())
       ->appendChild(
@@ -108,7 +109,7 @@ public function render() {
           ->setID('comment-content')
           ->setLabel(pht('Comment'))
           ->setValue($this->draft ? $this->draft->getDraft() : null)
-          ->setUser($this->user))
+          ->setViewer($viewer))
       ->appendChild(
         id(new AphrontFormSubmitControl())
           ->setValue(pht('Submit')));

src/applications/differential/view/DifferentialChangesetListView.php

@@ -113,6 +113,8 @@ public function setRawFileURIs($l, $r) {
   }
 
   public function render() {
+    $viewer = $this->getViewer();
+
     $this->requireResource('differential-changeset-view-css');
 
     $changesets = $this->changesets;
@@ -148,7 +150,7 @@ public function render() {
       ));
 
     $renderer = DifferentialChangesetParser::getDefaultRendererForViewer(
-      $this->getUser());
+      $viewer);
 
     $output = array();
     $ids = array();
@@ -163,7 +165,7 @@ public function render() {
       $ref = $this->references[$key];
 
       $detail = id(new DifferentialChangesetDetailView())
-        ->setUser($this->getUser());
+        ->setUser($viewer);
 
       $uniq_id = 'diff-'.$changeset->getAnchorName();
       $detail->setID($uniq_id);
@@ -261,6 +263,7 @@ private function renderViewOptionsDropdown(
     DifferentialChangesetDetailView $detail,
     $ref,
     DifferentialChangeset $changeset) {
+    $viewer = $this->getViewer();
 
     $meta = array();
 
@@ -280,7 +283,7 @@ private function renderViewOptionsDropdown(
       try {
         $meta['diffusionURI'] =
           (string)$repository->getDiffusionBrowseURIForPath(
-            $this->user,
+            $viewer,
             $changeset->getAbsoluteRepositoryPath($repository, $this->diff),
             idx($changeset->getMetadata(), 'line:first'),
             $this->getBranch());
@@ -308,13 +311,12 @@ private function renderViewOptionsDropdown(
       }
     }
 
-    $user = $this->user;
-    if ($user && $repository) {
+    if ($viewer && $repository) {
       $path = ltrim(
         $changeset->getAbsoluteRepositoryPath($repository, $this->diff),
         '/');
       $line = idx($changeset->getMetadata(), 'line:first', 1);
-      $editor_link = $user->loadEditorLink($path, $line, $repository);
+      $editor_link = $viewer->loadEditorLink($path, $line, $repository);
       if ($editor_link) {
         $meta['editor'] = $editor_link;
       } else {

src/applications/differential/view/DifferentialLocalCommitsView.php

@@ -17,10 +17,7 @@ public function setCommitsForLinks(array $commits) {
   }
 
   public function render() {
-    $user = $this->user;
-    if (!$user) {
-      throw new PhutilInvalidStateException('setUser');
-    }
+    $viewer = $this->getViewer();
 
     $local = $this->localCommits;
     if (!$local) {
@@ -94,7 +91,7 @@ public function render() {
         idx($commit, 'date'),
         idx($commit, 'time'));
       if ($date) {
-        $date = phabricator_datetime($date, $user);
+        $date = phabricator_datetime($date, $viewer);
       }
       $row[] = $date;
 

src/applications/differential/view/DifferentialRevisionListView.php

@@ -57,10 +57,7 @@ public function setHandles(array $handles) {
   }
 
   public function render() {
-    $user = $this->user;
-    if (!$user) {
-      throw new PhutilInvalidStateException('setUser');
-    }
+    $viewer = $this->getViewer();
 
     $fresh = PhabricatorEnv::getEnvConfig('differential.days-fresh');
     if ($fresh) {
@@ -83,12 +80,12 @@ public function render() {
 
     foreach ($this->revisions as $revision) {
       $item = id(new PHUIObjectItemView())
-        ->setUser($user);
+        ->setUser($viewer);
 
       $icons = array();
 
       $phid = $revision->getPHID();
-      $flag = $revision->getFlag($user);
+      $flag = $revision->getFlag($viewer);
       if ($flag) {
         $flag_class = PhabricatorFlagColor::getCSSClass($flag->getColor());
         $icons['flag'] = phutil_tag(
@@ -99,7 +96,7 @@ public function render() {
           '');
       }
 
-      if ($revision->getDrafts($user)) {
+      if ($revision->getDrafts($viewer)) {
         $icons['draft'] = true;
       }
 

src/applications/diffusion/view/DiffusionTagListView.php

@@ -100,7 +100,7 @@ public function render() {
         $build,
         $author,
         $description,
-        phabricator_datetime($tag->getEpoch(), $this->user),
+        phabricator_datetime($tag->getEpoch(), $this->getViewer()),
       );
     }
 

src/applications/phame/view/PhameBlogListView.php

@@ -3,19 +3,13 @@
 final class PhameBlogListView extends AphrontTagView {
 
   private $blogs;
-  private $viewer;
 
   public function setBlogs($blogs) {
     assert_instances_of($blogs, 'PhameBlog');
     $this->blogs = $blogs;
     return $this;
   }
 
-  public function setViewer($viewer) {
-    $this->viewer = $viewer;
-    return $this;
-  }
-
   protected function getTagAttributes() {
     $classes = array();
     $classes[] = 'phame-blog-list';

src/applications/phame/view/PhameDraftListView.php

@@ -4,7 +4,6 @@ final class PhameDraftListView extends AphrontTagView {
 
   private $posts;
   private $blogs;
-  private $viewer;
 
   public function setPosts($posts) {
     assert_instances_of($posts, 'PhamePost');
@@ -18,11 +17,6 @@ public function setBlogs($blogs) {
     return $this;
   }
 
-  public function setViewer($viewer) {
-    $this->viewer = $viewer;
-    return $this;
-  }
-
   protected function getTagAttributes() {
     $classes = array();
     $classes[] = 'phame-blog-list';