Fix default embedding model in README and enforce LF line endings#37
Merged
carlos-alm merged 2 commits intomainfrom Feb 23, 2026
Merged
Fix default embedding model in README and enforce LF line endings#37carlos-alm merged 2 commits intomainfrom
carlos-alm merged 2 commits intomainfrom
Conversation
The release step was staging all files, which committed native .node binaries and pkg/ directories into the release branch. Now only package.json, package-lock.json, CHANGELOG.md, and DEPENDENCIES.md are staged for the version bump commit.
…dings The README models table incorrectly marked minilm as the default embedding model. The actual default is jina-code (config.js, embedder.js, cli.js). Also adds .gitattributes to enforce LF line endings, fixing 32 Biome format errors caused by CRLF on Windows checkouts.
Contributor
Greptile SummaryThis PR fixes a documentation error in the README and adds line ending enforcement to prevent formatting issues. The README incorrectly labeled Key changes:
Confidence Score: 5/5
Important Files Changed
Last reviewed commit: c852707 |
3 tasks
carlos-alm
added a commit
that referenced
this pull request
Mar 21, 2026
- GitNexus overall score corrected from 4.7 to 4.5 to match the arithmetic mean of its six sub-scores (5+5+4+4+4+5)/6 = 4.5 - Tier 2 renumbered starting at #38 (was duplicating #37 with Tier 1); also resolves the pre-existing duplicate #43 (Bikach/ChrisRoyse now #44/#45), with all subsequent entries incremented accordingly - jelly section header updated from 417 to 423 stars to match the ranking table
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
minilmas the default embedding model — the actual default isjina-code(as set inconfig.js,embedder.js, andcli.js).gitattributeswith* text=auto eol=lfto prevent CRLF line endings on Windows, which were causing 32 Biome format errorsTest plan
npm run lintpasses cleanjina-code (default).gitattributesenforces LF on fresh clone