Skip to content

Fix default embedding model in README and enforce LF line endings#37

Merged
carlos-alm merged 2 commits intomainfrom
fix/combined-pending-changes
Feb 23, 2026
Merged

Fix default embedding model in README and enforce LF line endings#37
carlos-alm merged 2 commits intomainfrom
fix/combined-pending-changes

Conversation

@carlos-alm
Copy link
Contributor

Summary

  • Fix README models table incorrectly marking minilm as the default embedding model — the actual default is jina-code (as set in config.js, embedder.js, and cli.js)
  • Add .gitattributes with * text=auto eol=lf to prevent CRLF line endings on Windows, which were causing 32 Biome format errors
  • CI workflow hardening: validate version input, resilient publish steps, fix deps:tree script

Test plan

  • Verify npm run lint passes clean
  • Verify README models table shows jina-code (default)
  • Confirm .gitattributes enforces LF on fresh clone

The release step was staging all files, which committed native .node
binaries and pkg/ directories into the release branch. Now only
package.json, package-lock.json, CHANGELOG.md, and DEPENDENCIES.md
are staged for the version bump commit.
…dings

The README models table incorrectly marked minilm as the default
embedding model. The actual default is jina-code (config.js, embedder.js,
cli.js). Also adds .gitattributes to enforce LF line endings, fixing
32 Biome format errors caused by CRLF on Windows checkouts.
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 23, 2026

Greptile Summary

This PR fixes a documentation error in the README and adds line ending enforcement to prevent formatting issues. The README incorrectly labeled minilm as the default embedding model when the actual default is jina-code (verified in config.js:22, embedder.js:58, and cli.js:312).

Key changes:

  • Corrected README models table to show jina-code as default
  • Added .gitattributes with eol=lf to prevent CRLF issues that cause Biome format errors on Windows
  • Improved publish workflow to stage only version bump files (package.json, package-lock.json, CHANGELOG.md, DEPENDENCIES.md) instead of using git add -A, preventing build artifacts from being committed to release branches

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • All changes are straightforward documentation fixes and configuration improvements with no functional code changes. The README correction matches the actual default values in the codebase, .gitattributes properly enforces LF line endings to prevent platform-specific formatting issues, and the workflow change prevents unintended file commits.
  • No files require special attention

Important Files Changed

Filename Overview
.gitattributes Added .gitattributes to enforce LF line endings, preventing CRLF-related Biome format errors
README.md Corrected embedding model table to show jina-code as default instead of minilm
.github/workflows/publish.yml Improved version bump commit to stage only specific files, preventing build artifacts from being committed

Last reviewed commit: c852707

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@carlos-alm carlos-alm merged commit 4f3000b into main Feb 23, 2026
13 of 16 checks passed
@carlos-alm carlos-alm deleted the fix/combined-pending-changes branch February 23, 2026 03:31
@carlos-alm carlos-alm restored the fix/combined-pending-changes branch February 23, 2026 03:55
@carlos-alm carlos-alm deleted the fix/combined-pending-changes branch February 23, 2026 05:50
carlos-alm added a commit that referenced this pull request Mar 21, 2026
- GitNexus overall score corrected from 4.7 to 4.5 to match the
  arithmetic mean of its six sub-scores (5+5+4+4+4+5)/6 = 4.5
- Tier 2 renumbered starting at #38 (was duplicating #37 with Tier 1);
  also resolves the pre-existing duplicate #43 (Bikach/ChrisRoyse now
  #44/#45), with all subsequent entries incremented accordingly
- jelly section header updated from 417 to 423 stars to match the
  ranking table
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant