-
Notifications
You must be signed in to change notification settings - Fork 4
fix: add debug logging to empty catch blocks across infrastructure and domain #616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
94bd220
fix: add debug logging to empty catch blocks across infrastructure an…
carlos-alm feba0a4
Merge remote-tracking branch 'origin/main' into fix/titan-empty-catch…
carlos-alm c9eb01a
Merge branch 'main' into fix/titan-empty-catch-logging
carlos-alm 31cf7ae
Merge branch 'main' into fix/titan-empty-catch-logging
carlos-alm 05133b7
Merge branch 'main' into fix/titan-empty-catch-logging
carlos-alm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(e as Error).messageunsafe for non-Error throwsThe pattern
(e as Error).messageis used consistently across all 4 changed files. In TypeScript strict mode,eisunknown, and if anything other than anErrorinstance is thrown (e.g. a plain string,null, or a non-standard exception from the WASM layer),.messagewill beundefined, producing unhelpful log output likereadPackageExports: failed to read package.json in /path: undefined.A safer, idiomatic alternative:
The same pattern appears in all new
debug()calls across these files:src/infrastructure/config.ts:315, 349, 367src/infrastructure/native.ts:31, 98src/domain/graph/resolve.ts:70, 522, 544, 585src/domain/parser.ts:443, 462, 576, 582For the Node.js built-ins (
fs,JSON.parse,require) these always throwErrorinstances, so the risk is low in practice — but the WASMtree.delete()calls could theoretically throw a non-Errorvalue.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in follow-up PR #630 — all 14 occurrences of \ in this PR's catch blocks have been replaced with \ for safe handling of non-Error throws.