chore(deps): upgrade TypeScript from 5.9 to 6.0#667
Conversation
Remove unused baseUrl and paths from tsconfig.json (zero imports reference them) which TS 6.x deprecates (TS5101). Bump typescript devDependency to ^6.0.2.
|
Claude finished @carlos-alm's task —— View job TypeScript 6.0 Upgrade ReviewRoot Cause AnalysisProblem Being Solved: Fixing TS5101 error where Why This Approach: The PR removes Risk Assessment: Low risk. While the path aliases could improve code maintainability, their removal doesn't break functionality since the codebase already uses relative imports throughout. Backlog Compliance
Critical ConcernsMissing Opportunity for Code QualityThe removed path aliases ( // Current: src/cli/commands/audit.ts:1-4
import { collectFile } from '../../db/query-builder.js';
import { EVERY_SYMBOL_KIND } from '../../domain/queries.js';
import { audit } from '../../presentation/audit.js';
import { explain } from '../../presentation/queries-cli.js';
// Could be (with path aliases):
import { collectFile } from '#db/query-builder.js';
import { EVERY_SYMBOL_KIND } from '#domain/queries.js';
import { audit } from '#presentation/audit.js';
import { explain } from '#presentation/queries-cli.js';Alternative SolutionsInstead of removing the aliases entirely, consider:
Final Recommendation
Conditions for approval:
The PR successfully unblocks TypeScript 6.0 adoption without breaking changes, making it acceptable despite the missed modernization opportunity. |
Greptile SummaryThis PR upgrades TypeScript from
Confidence Score: 5/5Safe to merge — minimal, well-scoped changes with zero production-code modifications. All changes are in build tooling (devDependency bump, lockfile, tsconfig). No source code was modified. The tsconfig cleanup is confirmed safe (no path-alias imports anywhere in src/). The lockfile correction for @modelcontextprotocol/sdk is an accurate reflection of package.json. No P0 or P1 issues found. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[npm install typescript@6.0.2] --> B[tsc resolves modules]
B --> C{baseUrl / paths present?}
C -- "Old config (TS 5.x)" --> D[TS5101 warning/error in TS 6.x]
C -- "Removed in this PR" --> E[Clean compile — no TS5101]
E --> F{Any imports used #shared/* aliases?}
F -- "0 found in src/" --> G[All imports already used relative .js paths]
G --> H[npm run build passes]
G --> I[npm test: 2129/2129 pass]
Reviews (1): Last reviewed commit: "chore(deps): upgrade TypeScript from 5.9..." | Re-trigger Greptile |
|
Addressed Claude's review feedback:
The PR itself is clean: zero source code changes, CI is fully green (all 2129 tests pass, lint clean, type check clean), and both reviewers confirmed no path-alias imports exist in the codebase. |
Summary
typescriptdevDependency from^5.9.3to^6.0.2baseUrlandpathsfromtsconfig.json— zero imports in the codebase reference path aliases (all 849+ imports use relative paths with.jsextensions), so these were dead configbaseUrldeprecated in TS 6.x) that blocked Dependabot PR chore(deps-dev): bump typescript from 5.9.3 to 6.0.2 #663Test plan
npx tsc --noEmitpasses with zero errorsnpm run buildproducesdist/successfullynpm run lintpasses (no new warnings)npm test— 2129/2129 tests passnpx codegraph --helpworksCloses #663