Skip to content

Stale .js usage comments in scripts/*.ts and husky hooks reference removed src/cli.js #1975

Description

@carlos-alm

Found while fixing #1831 (stale CONTRIBUTING.md). Out of scope for that doc-only fix.

Stale Usage: node scripts/X.js header comments

These scripts were renamed to .ts (run via node scripts/node-ts.js scripts/X.ts) but their own doc-comment headers still say .js:

  • scripts/benchmark.tsUsage: node scripts/benchmark.js
  • scripts/build-wasm.ts — same pattern
  • scripts/embedding-benchmark.tsUsage: node scripts/embedding-benchmark.js > result.json
  • scripts/query-benchmark.tsUsage: node scripts/query-benchmark.js > result.json
  • scripts/incremental-benchmark.tsUsage: node scripts/incremental-benchmark.js > result.json

Husky hooks reference removed src/cli.js

.husky/pre-commit and .husky/commit-msg both fall back to node src/cli.js build . / node src/cli.js diff-impact ... if the global codegraph binary isn't on PATH. src/cli.js doesn't exist anymore (source is src/cli.ts, compiled output is dist/cli.js) — the fallback silently no-ops (|| true / || true swallows the failure), so on any machine without a global codegraph install, the pre-commit graph rebuild and commit-msg impact summary silently never run.

Suggested fix: point the fallback at dist/cli.js (with a npm run build prerequisite note) or drop the fallback and require the global binary.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions