fix(builder): remove duplicate early-return in backfillNativeDroppedFiles

[carlos-alm]

Summary

• Remove an unreachable duplicate if (missingAbs.length === 0) return; in backfillNativeDroppedFiles — the first identical check on the preceding line guaranteed the second could never execute.

Test plan

• npm run lint -- src/domain/graph/builder/pipeline.ts clean for the modified file.
• Behavior is a no-op (dead-code removal only).

Closes #1144

Note: tests/integration/dropped-language-gap.test.ts has 2 pre-existing failures on main unrelated to this change — tracked separately in #1147.

[claude]

Claude finished @carlos-alm's task —— View job

---

PR Review Complete ⭐⭐⭐⭐☆

Conducted comprehensive review of dead code removal PR following the 5-phase process:

• Phase 1: Root cause analysis - understand the problem being solved
• Phase 2: Configuration change detection - check for high-risk changes
• Phase 3: Test integrity - verify no test weakening
• Phase 4: Code quality assessment
• Phase 5: Backlog compliance evaluation

---

Root Cause Analysis

Problem Being Solved: Dead code removal - duplicate early-return check in backfillNativeDroppedFiles function
Why This Approach: The second if (missingAbs.length === 0) return; at lines 1026-1027 was unreachable because an identical check at line 1024 would already exit the function
Risk Assessment: Zero risk - this is pure dead code removal with no behavior change

Configuration Change Detection

✅ No configuration changes detected - this is a simple 2-line deletion with no config/linting/build modifications

Test Integrity

✅ No test changes - no test files modified, no assertions weakened, no coverage thresholds lowered

Code Quality

✅ High quality change:

• Improves code clarity by removing unreachable code
• No potential for introducing bugs
• Change is isolated to a single function
• Code flow logic remains identical

Backlog Compliance

• Zero-dep: ✅ — no new dependencies added
• Foundation-aligned: ✅ — code cleanup aligns with maintenance principles
• Problem-fit: 3 — housekeeping/maintenance, doesn't directly address AI navigation but improves code health
• Breaking: No — behavior is identical (no-op removal)
• Tier: 1

Critical Concerns

None. This is a textbook example of safe dead code removal.

Final Recommendation

• Rating: ⭐⭐⭐⭐☆ (4/5)
• Action: APPROVE
• Reasoning: Perfect dead code removal with zero risk. The duplicate check is clearly unreachable, the change improves code quality, and there are no test integrity or configuration concerns. Only reason it's not 5 stars is that it's a minor maintenance fix rather than a significant improvement.

---

[greptile-apps]

Greptile Summary

Removes a duplicate if (missingAbs.length === 0) return; guard in backfillNativeDroppedFiles that was unreachable because the identical check on the line immediately above it already exits the function.

• The deleted line was dead code — control flow could never reach it, so removing it has no observable effect on runtime behaviour.

Confidence Score: 5/5

Safe to merge — this is a pure dead-code removal with no change to runtime behaviour.

The only change is deleting a guard that could never execute, because the identical guard on the line above already exits the function. The surrounding logic is untouched and the deletion is a strict no-op.

No files require special attention.

Important Files Changed

Filename	Overview
src/domain/graph/builder/pipeline.ts	Removed a duplicate unreachable if (missingAbs.length === 0) return; guard; no behaviour change.

_{Reviews (4): Last reviewed commit: "Merge branch 'main' into fix/duplicate-e..." | Re-trigger Greptile}

[github-actions]

Codegraph Impact Analysis

1 functions changed → 4 callers affected across 3 files

• backfillNativeDroppedFiles in src/domain/graph/builder/pipeline.ts:991 (4 transitive callers)