Skip to content

docs: cold architectural audit + publish workflow fix#17

Merged
carlos-alm merged 4 commits intomainfrom
docs/architecture-audit
Feb 22, 2026
Merged

docs: cold architectural audit + publish workflow fix#17
carlos-alm merged 4 commits intomainfrom
docs/architecture-audit

Conversation

@carlos-alm
Copy link
Copy Markdown
Contributor

Summary

  • Architecture audit (architecture.md): 18 unconstrained redesign proposals covering modularity, data access, pipeline design, scalability, and extensibility — prioritized by architectural impact
  • Publish workflow fix: Pin checkout to ref: main so the publish job always checks out the correct branch
  • Lockfile sync: Update native optional dep versions from 1.3.0 → 1.4.0 to match current release

Test plan

  • Verify architecture.md renders correctly on GitHub
  • Verify npm run lint passes
  • Confirm publish workflow checkout change is correct

Comprehensive analysis of current architecture covering modularity,
data access patterns, pipeline design, and scalability gaps — with
concrete target shapes and priority ordering.
Add ref: main to publish workflow checkout step to ensure correct
branch. Update package-lock.json native optional deps from 1.3.0
to 1.4.0 to match current release.
The push step tried to run on release-triggered builds where the tag
already exists on the remote. Restrict push to workflow_dispatch only.
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Feb 22, 2026

Greptile Summary

Adds comprehensive architectural audit document and fixes publish workflow to correctly handle release events.

Major changes:

  • New architecture.md with 18 unconstrained redesign proposals covering parser modularity, repository pattern, pipeline architecture, and API surface design
  • Publish workflow now pins checkout to ref: main ensuring correct branch is used
  • Publish workflow skips version bump when triggered by release event (prevents double-versioning)
  • Push step now only runs on workflow_dispatch events, not release events
  • Native optional dependency versions synced to 1.4.0 in lockfile

The workflow changes prevent version conflicts when publish is triggered by a release event that already contains the versioned code.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • Changes are well-scoped: documentation addition, workflow logic fix with correct conditional logic, and lockfile version sync. No functional code changes to core library. Workflow changes fix a legitimate issue with release-triggered publishes.
  • No files require special attention

Important Files Changed

Filename Overview
.github/workflows/publish.yml Pins checkout to ref: main and adds release event check to skip version bump when triggered by release
architecture.md New architectural audit doc with 18 redesign proposals prioritized by impact
package-lock.json Syncs native optional dependency versions from 1.3.0 → 1.4.0 to match current release

Last reviewed commit: 880194e

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@carlos-alm carlos-alm merged commit 3fd551a into main Feb 22, 2026
15 checks passed
@carlos-alm carlos-alm deleted the docs/architecture-audit branch February 22, 2026 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant