feat: implement dogfood report suggestions#70
Conversation
- Add `excludeTests` config option with `--include-tests` CLI override - Add coupling score column to `map` command output - Add `--depth` option to `explain` for recursive dependency explanation - Move engine status messages from stdout to stderr via logger - Update DOGFOOD-REPORT-2.1.0 marking all suggestions as implemented Impact: 8 functions changed, 5 affected
|
Claude finished @carlos-alm's task —— View job PR Review: feat: implement dogfood report suggestionsPhase 1: Root Cause Analysis
Phase 2: Configuration Change Detection
Phase 3: Test Integrity
Phase 4: Code Quality Review
Final Assessment
Root Cause AnalysisProblem Being Solved: Five specific usability gaps identified through comprehensive dogfooding of codegraph v2.1.0 on itself. These are legitimate issues: missing CLI options that existed in the data layer, inconsistent output formatting, Windows compatibility problems, and stdout pollution. Why This Approach: All fixes are targeted and conservative. No major architectural changes, just connecting existing functionality to the CLI and improving output consistency. Risk Assessment: Very low risk. Changes are primarily additive CLI options, display formatting, and fixing missing shebangs. Critical ConcernsNone identified. This is a clean, well-implemented PR that addresses real usability issues without introducing technical debt or risky configuration changes. Positive observations:
Final Recommendation
Recommendation: Approve and merge. This exemplifies good dogfooding practice - identifying real pain points through usage and addressing them systematically. |
Greptile SummaryThis PR implements all 5 suggestions from DOGFOOD-REPORT-2.1.0: adds Key changes:
All integration tests pass (67/67), test spies correctly updated to check stderr instead of stdout. Confidence Score: 5/5
Important Files Changed
Last reviewed commit: 242066f |
| .option('--include-test-source', 'Include test source code') | ||
| .option('-T, --no-tests', 'Exclude test/spec files from results') | ||
| .option('--include-tests', 'Include test/spec files (overrides excludeTests config)') |
There was a problem hiding this comment.
Consider renaming --include-test-source to something like --with-test-source to distinguish it from --include-tests (which controls test file filtering, not test source inclusion)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
|
Claude finished @carlos-alm's task —— View job PR Review: feat: implement dogfood report suggestionsPhase 1: Root Cause Analysis
Phase 2: Configuration Change Detection
Phase 3: Test Integrity
Phase 4: Code Quality Review
Final Assessment
Root Cause AnalysisProblem Being Solved: Five specific usability gaps identified through comprehensive dogfooding of codegraph v2.1.0 on itself. These are legitimate issues: missing CLI options that existed in the data layer, inconsistent output formatting, Windows compatibility problems, and stdout pollution. Why This Approach: All fixes are targeted and conservative. No major architectural changes, just connecting existing functionality to the CLI and improving output consistency. Risk Assessment: Very low risk. Changes are primarily additive CLI options, display formatting, and fixing missing shebangs. Critical ConcernsNone identified. This is a clean, well-implemented PR that addresses real usability issues without introducing technical debt or risky configuration changes. Positive observations:
Final Recommendation
Recommendation: Approve and merge. This exemplifies good dogfooding practice - identifying real pain points through usage and addressing them systematically. |
|
Claude finished @carlos-alm's task —— View job PR Review: feat: implement dogfood report suggestionsPhase 1: Root Cause Analysis
Phase 2: Configuration Change Detection
Phase 3: Test Integrity
Phase 4: Code Quality Review
Final Assessment
Root Cause AnalysisProblem Being Solved: Five specific usability gaps identified through comprehensive dogfooding of codegraph v2.1.0 on itself. These are legitimate issues: missing CLI options that existed in the data layer, inconsistent output formatting, Windows compatibility problems, and stdout pollution. Why This Approach: All fixes are targeted and conservative. No major architectural changes, just connecting existing functionality to the CLI and improving output consistency. Risk Assessment: Very low risk. Changes are primarily additive CLI options, display formatting, and fixing missing shebangs. Critical ConcernsNone identified. This is a clean, well-implemented PR that addresses real usability issues without introducing technical debt or risky configuration changes. Positive observations:
Final Recommendation
Recommendation: Approve and merge. This exemplifies good dogfooding practice - identifying real pain points through usage and addressing them systematically. |
Summary
excludeTestsconfig option (query.excludeTestsin.codegraphrc.json) with--include-testsCLI override on all commands=NNN) tomapcommand output--depth <n>option toexplainfor recursive dependency explanation#!/bin/shshebangs on all husky hooks (Windows compatibility)Test plan
npm run lint— cleancodegraph where explain -T— excludes test filescodegraph where explain --include-tests— includes test filescodegraph explain buildGraph --depth 1 -T— recursively explains calleescodegraph explain openDb --depth 1 -T -j— JSON output with depth workscodegraph map -T— shows=NNNcoupling column