Conversation
Contributor
Ronan-pdr
commented
Oct 23, 2021
Ronan-pdr
commented
- Split the width and height in 9
- 81 blocks of 28 x 28 pixels in a SDL_Surface* array
- Only the number there is a clean of the black lines
Contributor
Author
|
AHAHAH I can not make the changes here ... |
Contributor
Author
|
@QuentinAM the function to use for segmentation is in split9, @Renaud-Dov is going to the shower so he cant review. If u want to do it feel free. |
Contributor
|
you don't need to talk about my personal life on a GitHub review 👀 |
QuentinAM
reviewed
Oct 23, 2021
| if (nbblack == 0) | ||
| return 1; | ||
| // printf("sur la colone %d il y a %d block noir\n",x,nbblack); | ||
| return nbblack > 20 ? 1 : 0; |
Member
There was a problem hiding this comment.
Need to delete all commented printf in french !!
| for(unsigned int i = 0; i < 56; i++){ | ||
| printf("%d,",cor[i]); | ||
| } | ||
| printf("]\n");*/ |
|
|
||
| SDL_Rect block; | ||
| unsigned int yinit = coorarray[0].ystart; | ||
| const unsigned int ytaille = coorarray[0].yend - coorarray[0].ystart; |
| printf("je suis la\n"); | ||
|
|
||
| resize(&imagebis, 28, 28); | ||
| printf("Apres resize widthnew: %d, heightnew: %d\n", imagebis.width, |
Member
There was a problem hiding this comment.
A lot of useless print + one in french
|
|
||
| if (save) | ||
| { | ||
| printf("je save ta mère\n"); |
| image->height = height; | ||
|
|
||
| image->pixels = malloc((width + 1) * sizeof(Pixel *)); | ||
| image->pixels = calloc(width, sizeof(Pixel *)); |
Member
There was a problem hiding this comment.
Why replace this by a calloc ?
Contributor
Author
There was a problem hiding this comment.
Paul had advised to do this when I had memory problems this morning, moreover he advised us when he helped Matthew to always use calloc when we can and not malloc
QuentinAM
approved these changes
Oct 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.