[BUG-8620] Add ProGuard keep rules for Jackson naming strategy#531
Open
muzahidul-opti wants to merge 1 commit into
Open
[BUG-8620] Add ProGuard keep rules for Jackson naming strategy#531muzahidul-opti wants to merge 1 commit into
muzahidul-opti wants to merge 1 commit into
Conversation
Prevents R8 from obfuscating PropertyNamingStrategies.SNAKE_CASE and PropertyNamingStrategy.SNAKE_CASE fields that the Java SDK's JacksonSerializer accesses via reflection. Without these rules, apps with Jackson on the classpath get NoClassDefFoundError in DefaultJsonSerializer. Defense-in-depth for BUG-8620 (primary fix is in java-sdk). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-keepclassmembersrules forPropertyNamingStrategiesandPropertyNamingStrategyto prevent R8 from obfuscating theSNAKE_CASEfield thatJacksonSerializer.getSnakeCaseStrategy()accesses via reflectionContext
PetSmart has Jackson on their classpath as a transitive dependency, with a keep rule preserving
ObjectMapperclass name but notPropertyNamingStrategies. R8 obfuscates theSNAKE_CASEfield, causingNoSuchFieldException→RuntimeException→NoClassDefFoundErrorinDefaultJsonSerializer.Same class of bug as ae380e9 ("R8: Keep name of
Gsonclass (#493)").Companion PR: optimizely/java-sdk#626 (primary resilience fix)
Test plan
minifyEnabled trueand Jackson on classpathIssue
🤖 Generated with Claude Code