[FSSDK-11552] Fix holdouts bug in activate endpoint #429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riation info This change fixes a bug where GetDetailedFeatureDecisionUnsafe did not return experimentKey and variationKey for holdout decisions, only for feature tests. Holdouts are control groups that need experiment/variation tracking for analytics, similar to feature tests. This aligns the go-sdk with the Swift SDK reference implementation, which includes experiment and variation info for all decision sources except rollouts. Changes: - Updated client.go:878 to include decision.Holdout alongside decision.FeatureTest - Added test case TestGetDetailedFeatureDecisionUnsafeWithHoldoutAndTrackingEnabled - Updated comment to clarify that holdouts should include experiment/variation info
pvcraven
reviewed
Dec 9, 2025
pvcraven
left a comment
pvcraven
left a comment
There was a problem hiding this comment.
Return experimentKey and variationKey for holdout decisions as well as feature tests
pvcraven
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a bug where GetDetailedFeatureDecisionUnsafe did not return experimentKey and variationKey for holdout decisions, only for feature tests.
Changes:
https://optimizely-ext.atlassian.net/browse/FSSDK-11552