Skip to content

Conversation

@yasirfolio3
Copy link
Contributor

@yasirfolio3 yasirfolio3 commented Aug 22, 2019

Summary

  • Add GetFeatureVariableBoolean as a function in client.go
  • Add GetFeatureVariableDouble as a function in client.go
  • Add GetFeatureVariableInteger as a function in client.go
  • Add GetFeatureVariableString as a function in client.go
  • Add GetFeatureFlagByKey() function in datafileprojectconfig/config.go
  • Add GetVariable() function in FeatureFlag entity
  • Add MapFeatureFlags() function in datafileprojectconfig/mappers/feature.go

Tests

  • Unit tests in client_test.go

Issues

OASIS-5006

@yasirfolio3 yasirfolio3 requested a review from a team as a code owner August 22, 2019 11:48
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please break up the PR a little by first introducing GetFeatureVariableString. Once we approve and merge that in then we'll add the rest of em. It just makes reviewing easier.

@yasirfolio3
Copy link
Contributor Author

Please break up the PR a little by first introducing GetFeatureVariableString. Once we approve and merge that in then we'll add the rest of em. It just makes reviewing easier.

done, closing this PR for now, please review #71 .

@yasirfolio3 yasirfolio3 deleted the yasir/get-feature-variable branch August 27, 2019 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants