Added isExperiment running check to avoid evaluating paused rollout experiments #453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1921
💛 - Coveralls |
Pull Request Test Coverage Report for Build 1903
💛 - Coveralls |
| int index = 0; | ||
| while (index < rolloutRulesLength) { | ||
|
|
||
| if (!rollout.getExperiments().get(index).isRunning()) { |
Contributor
There was a problem hiding this comment.
Should this check the status of the experiment to be "paused" rather than not isRunning since there are 4 other status'? Or is this behavior supposed to be for every status other than running?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
All FSC and unit tests should pass.