Deserialize integers as longs when using Gson#623
Open
jamiesanson wants to merge 4 commits intooptimizely:masterfrom
Open
Deserialize integers as longs when using Gson#623jamiesanson wants to merge 4 commits intooptimizely:masterfrom
jamiesanson wants to merge 4 commits intooptimizely:masterfrom
Conversation
jamiesanson
force-pushed
the
js/gson-deserialize-integers
branch
from
c3bc3c2 to
1062edf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deserialize integers as longs when using Gson. This allows users to then use the resultant
Mapin downstream serializers more easily.Note: This is a breaking change in the case where consumers were relying on the double output. It's more correct, so feels worth taking, but feel free to hold this PR until you plan to release a new major version!
Issues
Fixes #622