remove const declaration requirement

Author: raju-opti

.eslintrc.js

@@ -32,8 +32,6 @@ module.exports = {
       'files': ['lib/**/*.ts', 'src/**/*.ts'],
       'excludedFiles': [
         '**/platform_support.ts',
-        '**/common_exports.ts',
-        '**/export_types.ts',
         '**/*.spec.ts',
         '**/*.test.ts',
         '**/*.tests.ts',

.platform-isolation.config.js

@@ -15,9 +15,6 @@ module.exports = {
   exclude: [
     // Platform definition file (this file defines Platform type, doesn't need __platforms)
     '**/platform_support.ts',
-
-    // '**/common_exports.ts',
-    // '**/export_types.ts',
 
     // Test files
     '**/*.spec.ts',

eslint-local-rules/require-platform-declaration.js

@@ -46,9 +46,10 @@ module.exports = {
     },
     messages: {
       missingPlatformDeclaration: 'File must export __platforms to declare which platforms it supports. Example: export const __platforms = [\'__universal__\'];',
-      invalidPlatformDeclaration: '__platforms must be exported as a const array. Example: export const __platforms = [\'browser\', \'node\'];',
-      invalidPlatformValue: '__platforms contains invalid platform value "{{value}}". Valid platforms are: {{validPlatforms}}',
-      emptyPlatformArray: '__platforms array cannot be empty. Specify at least one platform or use [\'__universal__\']',
+      notArray: '__platforms must be an array literal. Example: export const __platforms = [\'browser\', \'node\'];',
+      emptyArray: '__platforms array cannot be empty. Specify at least one platform or use [\'__universal__\'].',
+      notLiterals: '__platforms must only contain string literals. Do NOT use variables, computed values, or spread operators.',
+      invalidValues: 'Invalid platform value "{{value}}". Valid platforms are: {{validPlatforms}}',
     },
     schema: [],
   },
@@ -69,15 +70,6 @@ module.exports = {
 
               hasPlatformExport = true;
 
-              // Validate it's a const
-              if (node.declaration.kind !== 'const') {
-                context.report({
-                  node: declarator,
-                  messageId: 'invalidPlatformDeclaration',
-                });
-                return;
-              }
-              
               // Validate it's an array expression
               let init = declarator.init;
 
@@ -94,7 +86,7 @@ module.exports = {
               if (!init || init.type !== 'ArrayExpression') {
                 context.report({
                   node: declarator,
-                  messageId: 'invalidPlatformDeclaration',
+                  messageId: 'notArray',
                 });
                 return;
               }
@@ -103,7 +95,7 @@ module.exports = {
               if (init.elements.length === 0) {
                 context.report({
                   node: init,
-                  messageId: 'emptyPlatformArray',
+                  messageId: 'emptyArray',
                 });
                 return;
               }
@@ -114,7 +106,7 @@ module.exports = {
                   if (!VALID_PLATFORMS.includes(element.value)) {
                     context.report({
                       node: element,
-                      messageId: 'invalidPlatformValue',
+                      messageId: 'invalidValues',
                       data: { 
                         value: element.value,
                         validPlatforms: VALID_PLATFORMS.map(p => `'${p}'`).join(', ')
@@ -125,7 +117,7 @@ module.exports = {
                   // Not a string literal
                   context.report({
                     node: element || init,
-                    messageId: 'invalidPlatformDeclaration',
+                    messageId: 'notLiterals',
                   });
                 }
               }

lib/utils/http_request_handler/request_handler.browser.ts

@@ -134,4 +134,4 @@ export class BrowserRequestHandler implements RequestHandler {
   }
 }
 
-export const __platforms: Platform[] = ['browser'];
+export const __platforms: Platform[] = ['browser', 'react_native'];

message_generator.ts

@@ -18,7 +18,7 @@ const generate = async () => {
     let genOut = '';
 
     Object.keys(exports).forEach((key, i) => {
-      if (key === 'messages') return;
+      if (key === 'messages' || key === '__platforms') return;
       genOut += `export const ${key} = '${i}';\n`;
       messages.push(exports[key])
     });

scripts/add-platform-exports.js

@@ -296,7 +296,7 @@ function processFile(filePath) {
 
   // Extract platforms and error info from result
   const existingPlatforms = result.success ? result.platforms : null;
-  const needsFixing = result.error && ['MISSING', 'NOT_CONST', 'NOT_ARRAY', 'EMPTY_ARRAY', 'NOT_LITERALS', 'INVALID_VALUES'].includes(result.error.type);
+  const needsFixing = result.error && ['MISSING', 'NOT_ARRAY', 'EMPTY_ARRAY', 'NOT_LITERALS', 'INVALID_VALUES'].includes(result.error.type);
 
   // Determine platforms for this file
   // If file already has valid platforms, use those (preserve existing values)
@@ -315,7 +315,7 @@ function processFile(filePath) {
   let action = 'skipped';
 
   if (needsFixing) {
-    // Has issues (MISSING, NOT_CONST, NOT_LITERALS, INVALID_VALUES, etc.), fix them
+    // Has issues (MISSING, NOT_ARRAY, NOT_LITERALS, INVALID_VALUES, etc.), fix them
     const extracted = extractExistingPlatformExport(content, filePath);
     if (extracted.removed) {
       content = extracted.content;

scripts/platform-utils.js

@@ -99,7 +99,6 @@ function getValidPlatforms(workspaceRoot) {
  */
 function extractPlatformsFromAST(sourceFile, filePath, validPlatforms) {
   let found = false;
-  let isConst = false;
   let isArray = false;
   let platforms = [];
   let hasNonStringLiteral = false;
@@ -113,15 +112,12 @@ function extractPlatformsFromAST(sourceFile, filePath, validPlatforms) {
       );
 
       if (hasExport) {
-        const isConstDecl = (node.declarationList.flags & ts.NodeFlags.Const) !== 0;
-        
         for (const declaration of node.declarationList.declarations) {
           if (ts.isVariableDeclaration(declaration) &&
               ts.isIdentifier(declaration.name) &&
               declaration.name.text === '__platforms') {
 
             found = true;
-            isConst = isConstDecl;
 
             let initializer = declaration.initializer;
 
@@ -172,16 +168,6 @@ function extractPlatformsFromAST(sourceFile, filePath, validPlatforms) {
     };
   }
 
-  if (!isConst) {
-    return {
-      success: false,
-      error: {
-        type: 'NOT_CONST',
-        message: `'__platforms' must be declared with 'const', found non-const declaration`
-      }
-    };
-  }
-  
   if (!isArray) {
     return {
       success: false,

scripts/validate-platform-isolation-ts.js

@@ -441,7 +441,6 @@ function main() {
   // Group errors by type
   const errorsByType = {
     MISSING: [],
-    NOT_CONST: [],
     NOT_ARRAY: [],
     EMPTY_ARRAY: [],
     NOT_LITERALS: [],
@@ -467,15 +466,6 @@ function main() {
     console.error(`\n${errorsByType.MISSING[0].error.message}\n`);
   }
 
-  if (errorsByType.NOT_CONST.length > 0) {
-    hasErrors = true;
-    console.error(`❌ Found ${errorsByType.NOT_CONST.length} file(s) with __platforms not declared as const:\n`);
-    for (const { filePath, error } of errorsByType.NOT_CONST) {
-      console.error(`  📄 ${path.relative(process.cwd(), filePath)}`);
-    }
-    console.error(`\n${errorsByType.NOT_CONST[0].error.message}\n`);
-  }
-  
   if (errorsByType.NOT_ARRAY.length > 0) {
     hasErrors = true;
     console.error(`❌ Found ${errorsByType.NOT_ARRAY.length} file(s) with __platforms not declared as an array:\n`);