Skip to content

fix (datafile manager) [OASIS-4715]: Rename top-level exports to avoid conflict with interface name #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2019
Merged

fix (datafile manager) [OASIS-4715]: Rename top-level exports to avoid conflict with interface name #291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78a0148
Rename export from DatafileManager to HttpPollingDatafileManager
Jun 10, 2019
66909c2
Add CHANGELOG entry, and standardize spelling of
Jun 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/datafile-manager/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
## [Unreleased]
Changes that have landed but are not yet released.

### Changed
- Changed name of top-level exports in index.node.ts and index.browser.ts from DatafileManager to HttpPollingDatafileManager, to avoid name conflict with DatafileManager interface

## [0.3.0] - May 13, 2019

### New Features
Expand Down
4 changes: 2 additions & 2 deletions packages/datafile-manager/__test__/httpPollingDatafileManager.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* limitations under the License.
*/

import HTTPPollingDatafileManager from '../src/httpPollingDatafileManager'
import HttpPollingDatafileManager from '../src/httpPollingDatafileManager'
import { Headers, AbortableRequest, Response } from '../src/http'
import { DatafileManagerConfig } from '../src/datafileManager';
import { advanceTimersByTime, getTimerCount } from './testUtils'
Expand All @@ -34,7 +34,7 @@ import BackoffController from '../src/backoffController'

// Test implementation:
// - Does not make any real requests: just resolves with queued responses (tests push onto queuedResponses)
class TestDatafileManager extends HTTPPollingDatafileManager {
class TestDatafileManager extends HttpPollingDatafileManager {
queuedResponses: (Response | Error)[] = []

responsePromises: Promise<Response>[] = []
Expand Down
4 changes: 2 additions & 2 deletions packages/datafile-manager/src/httpPollingDatafileManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ function isSuccessStatusCode(statusCode: number): boolean {
return statusCode >= 200 && statusCode < 400
}

export default abstract class HTTPPollingDatafileManager implements DatafileManager {
export default abstract class HttpPollingDatafileManager implements DatafileManager {
// Make an HTTP get request to the given URL with the given headers
// Return an AbortableRequest, which has a promise for a Response.
// If we can't get a response, the promise is rejected.
Expand Down Expand Up @@ -208,7 +208,7 @@ export default abstract class HTTPPollingDatafileManager implements DatafileMana
}
}

private onRequestComplete(this: HTTPPollingDatafileManager): void {
private onRequestComplete(this: HttpPollingDatafileManager): void {
if (!this.isStarted) {
return
}
Expand Down
2 changes: 1 addition & 1 deletion packages/datafile-manager/src/index.browser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,5 @@
*/

export * from './datafileManager'
export { default as DatafileManager } from './browserDatafileManager'
export { default as HttpPollingDatafileManager } from './browserDatafileManager'
export { default as StaticDatafileManager } from './staticDatafileManager';
2 changes: 1 addition & 1 deletion packages/datafile-manager/src/index.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,5 @@
*/

export * from './datafileManager'
export { default as DatafileManager } from './nodeDatafileManager'
export { default as HttpPollingDatafileManager } from './nodeDatafileManager'
export { default as StaticDatafileManager } from './staticDatafileManager';