feat(event processor): Send log event notification upon event dispatch when notification center available #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
August 6, 2019 19:49
mikeproeng37
suggested changes
Aug 8, 2019
Contributor
mikeproeng37
left a comment
mikeproeng37
left a comment
There was a problem hiding this comment.
lgtm, please rebase PR so we don't get changes from other PRs mixed in
| "dependencies": { | ||
| "@optimizely/js-sdk-logging": "^0.1.0", | ||
| "@optimizely/js-sdk-utils": "^0.1.0" | ||
| "@optimizely/js-sdk-utils": "^0.2.0" |
Contributor
There was a problem hiding this comment.
I think these changes are not supposed to be in this PR
Contributor
Author
There was a problem hiding this comment.
I did intend this. I'm updating to 0.2.0 so I can get access to NOTIFICATION_TYPES and NotificationCenter, new exports from js-sdk-utils. But did you want this update itself to be separated into its own PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With this change, the event processor can be constructed with a notification center. If a notification center is provided, it triggers a log event notification after the event is sent to the event dispatcher.
Test plan
Added new unit test. Manually tested
Issues
https://optimizely.atlassian.net/browse/OASIS-4976