fix(event processor): If batchSize = 0 or flushInterval = 0, log that values are invalid and use default values instead #342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d pick up default values instead
aliabbasrizvi
approved these changes
Aug 9, 2019
| } | ||
|
|
||
| const MIN_FLUSH_INTERVAL = 100 | ||
| const DEFAULT_FLUSH_INTERVAL = 30000 |
Contributor
There was a problem hiding this comment.
Can you add a comment about what this value is? i.e. this does not talk about unit so a simple comment about this being 30 seconds will be useful I feel.
|
|
||
| maxQueueSize = Math.floor(maxQueueSize) | ||
| if (maxQueueSize < 1) { | ||
| logger.warn(`Invalid maxQueueSize, defaulting to ${DEFAULT_MAX_QUEUE_SIZE}`) |
Contributor
There was a problem hiding this comment.
Let's log the invalid maxQueueSize value as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add/change validation for
maxQueueSizeandflushIntervalinputs toAbstractEventProcessor. When invalid, ignore and use default values.Test plan
New unit tests
Issues
OASIS-5167