Skip to content

Fixes e.replace is not a function error #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fixes e.replace is not a function error #720

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions packages/logging/src/logger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,15 +264,25 @@ class OptimizelyLogger implements LoggerFacade {
}
}

private namedLog(level: LogLevel, message: string | Error, splat: any[]): void {
private namedLog(level: LogLevel, message: unknown, splat: any[]): void {
let error: Error | undefined

if (message instanceof Error) {
error = message
message = error.message
this.internalLog(level, {
error,
message,
message: error.message,
splat,
})
return
}

// sometimes values other than Error are thrown and logged with the optimizely logger,
// we need to catch this case here to avoid a follow-up issue when calling format/sprintf with something else than a string for the message
if (typeof message !== 'string') {
this.internalLog(level, {
error,
message: `${message}`,
splat,
})
return
Expand Down