Add onRouteStart option#8
Merged
Merged
Conversation
| this.__currentCanonicalPath = canonicalPath | ||
|
|
||
| if (this.onRouteStart && mode !== 'replace') { | ||
| this.onRouteStart(); |
There was a problem hiding this comment.
I think it'd be good to supply some data to this function. Like the fromPath and make this threads through properly with redirects, as well as the startTime.
Thoughts?
Author
There was a problem hiding this comment.
Yea, good point, I'll pass fromPath and startTime. Could you clarify what you meant about redirects?
There was a problem hiding this comment.
Current canonical path might also be helpful for generalized onRouteStart functions. Would ctx be reasonable to be passed in as well?
There was a problem hiding this comment.
Yeah if we have Route A redirecting to Route B:
- Route A start (should call onStart)
- Route A redirect
- Route A end (never called)
- Route B start (should not call onStart)
- Route B end (should call onEnd)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jordangarcia This adds the onRouteStart option.