API - getEnabledFeatures #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
mikeproeng37
suggested changes
Dec 13, 2017
Contributor
mikeproeng37
left a comment
mikeproeng37
left a comment
There was a problem hiding this comment.
Mostly looks good. Just have a few comments on it.
src/Optimizely/Optimizely.php
Outdated
| */ | ||
| public function getEnabledFeatures($userId, $attributes = null) | ||
| { | ||
| $enabled_feature_keys = []; |
Contributor
There was a problem hiding this comment.
Please change all variables to camel case: $enabledFeatureKeys
| $this->assertEmpty($optimizelyMock->getEnabledFeatures("user_id", [])); | ||
| } | ||
|
|
||
| public function testGetEnabledFeaturesGivenFeaturesAreEnabledForUser() |
Contributor
There was a problem hiding this comment.
I'd suggest adding one more test case where the user also has attributes
Contributor
|
E2E tests pass. Going to merge this in. |
aliabbasrizvi
approved these changes
Dec 14, 2017
| foreach ($featureFlags as $feature){ | ||
| $featureKey = $feature->getKey(); | ||
| if ($this->isFeatureEnabled($featureKey, $userId, $attributes) === true) { | ||
| $enabledFeatureKeys[] = $featureKey; |
Contributor
There was a problem hiding this comment.
Wow. Wasn't aware of this syntax. Neat. Just make sure travis passes across all PHP versions.
Contributor
|
E2e tests are once again passing. Merging this PR in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.