Skip to content

[AI-FSSDK] [FSSDK-12670] Block ODP identify event for single identifier#513

Merged
FarhanAnjum-opti merged 6 commits into
masterfrom
ai/jaeopt/FSSDK-12670-odp-event
Jun 3, 2026
Merged

[AI-FSSDK] [FSSDK-12670] Block ODP identify event for single identifier#513
FarhanAnjum-opti merged 6 commits into
masterfrom
ai/jaeopt/FSSDK-12670-odp-event

Conversation

@jaeopt
Copy link
Copy Markdown
Contributor

@jaeopt jaeopt commented May 18, 2026

Summary

Fixes ODP identify event to only send when multiple identifiers exist. Previously, the SDK always sent an identify event when creating a user context, even with just a single fs_user_id. This wastes network calls and pollutes ODP identity graphs with single-identifier records that provide no linking value.

Changes

  • Changed identify_user method signature across the identify chain to accept an identifiers dict instead of a single user_id string
  • Added identifier count check in OdpEventManager.identify_user to skip sending when fewer than 2 valid identifiers are present
  • Filters out identifiers with None or empty string values before counting
  • Added debug-level logging when the identify event is skipped due to single identifier
  • Updated existing tests and added new tests for single-identifier blocking and empty-value filtering

Jira Ticket

FSSDK-12670

Copy link
Copy Markdown
Contributor

@FarhanAnjum-opti FarhanAnjum-opti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Confirmed the < 2 guard intentionally blocks the single fs_user_id from create_user_context. The dict refactoring is prep for future multi-identifier support.

@FarhanAnjum-opti FarhanAnjum-opti merged commit 9bf1c31 into master Jun 3, 2026
15 of 16 checks passed
@FarhanAnjum-opti FarhanAnjum-opti deleted the ai/jaeopt/FSSDK-12670-odp-event branch June 3, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants