Skip to content

Conversation

@esrakartalOpt
Copy link
Contributor

@esrakartalOpt esrakartalOpt commented Dec 8, 2025

Summary

  • Fixed Ruby Holdout implementation

Test plan

Issues

@esrakartalOpt esrakartalOpt changed the title Fix FSC tests [FSSDK-12094] Fix Ruby holdout implementation which related to FSC failures Dec 10, 2025
@esrakartalOpt esrakartalOpt marked this pull request as ready for review December 10, 2025 02:40
Copy link
Contributor

@muzahidul-opti muzahidul-opti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

decision_result.reasons.push(*decision_result_rollout.reasons)
end
decisions << decision_result
decision = get_decision_for_flag(feature_flag, user_context, project_config, decide_options, user_profile_tracker)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it looks better

@esrakartalOpt esrakartalOpt merged commit fe450dd into master Dec 11, 2025
9 checks passed
@esrakartalOpt esrakartalOpt deleted the esra/fix_FSC_tests branch December 11, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants