[FSSDK-11995] chore: expose cmab cache config #609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove extra space at the end of the Ruby SDK link
- Update max retries from 3 to 1 in CmabRetryConfig struct feat: add default values for cmab cache in DefaultCmabService - Add constants for DEFAULT_CMAB_CACHE_TIMEOUT and DEFAULT_CMAB_CACHE_SIZE - Assign DEFAULT_CMAB_CACHE_SIZE as 100 and DEFAULT_CMAB_CACHE_TIMEOUT as 600 - Change access control of cmabCache property to 'let' in DefaultCmabService feat: allow custom cache size and timeout for cmab cache in DefaultCmabService - Add new static function createDefault with parameters for cache size and timeout - Implement creation of DefaultCmabService with custom cache size and timeout feat: add cmab cache settings to OptimizelySdkSettings - Add cmabCacheSize and cmabCacheTitmeoutInSecs properties to OptimizelySdkSettings struct - Initialize properties with default values and update init method fix: update cmab cache settings initialization in OptimizelyClient - Update initialization of cmabService with size and timeout values from sdkSettings chore: refactor tests for cmab cache settings in OptimizelyClientTests_ODP - Modify test cases to check the cmabCacheSize and cmabCacheTitmeoutInSecs values build: remove unnecessary code from FakeDecisionService - Remove empty lines for cleanliness refactor: improve parameter passing in FakeDecisionService constructor - Modify the constructor to pass cmabService parameter explicitly in super.init
muzahidul-opti
changed the title
raju-opti
requested changes
Nov 3, 2025
…timeout calculation
…ULT_CMAB_CACHE_TIMEOUT and DEFAULT_CMAB_CACHE_SIZE
raju-opti
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Issues