fix(npm): verify release archive checksums#46
Open
saurabhhhcodes wants to merge 1 commit into
Open
Conversation
|
First PR — welcome aboard! A few things to expect:
If you get stuck, reply here or jump to Discussions. We want this PR to land. |
Signed-off-by: Saurabh Kumar Bajpai <saurabhhhcodes@users.noreply.github.com>
cb3884d to
a1cde9d
Compare
Author
|
All checks are green now and the branch is clean. If this contribution is eligible for GSSoC scoring, could you please add the appropriate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
checksums.txtfrom the matching GitHub release during npm postinstallFixes #28
Validation
npm run test:npmgit diff --checkGOFLAGS=-mod=mod make testNote: plain
make testcurrently stops before tests with the repo's existing vendor/modules.txt mismatch; rerunning withGOFLAGS=-mod=modfollows Go's suggested workaround and the full suite passes.